Merge pull request #1730 from groue/dev/issue-1728

Undeprecate Date coding strategies based on DateFormatter

Author: groue

GRDB/Record/EncodableRecord.swift

@@ -526,9 +526,9 @@ public enum DatabaseDataEncodingStrategy: Sendable {
 /// ```
 public enum DatabaseDateEncodingStrategy: @unchecked Sendable {
     // @unchecked Sendable because of `DateFormatter`, which lost its
-    // `Sendable` conformance with Xcode 16.3. See
+    // `Sendable` conformance with Xcode 16.3 beta. See
     // <https://github.com/swiftlang/swift/issues/78635>.
-    // TODO GRDB8: remove @unchecked when the .formatted case has been removed.
+    // TODO: remove @unchecked when the compiler issue is fixed.
 
     /// The strategy that uses formatting from the Date structure.
     ///
@@ -556,7 +556,6 @@ public enum DatabaseDateEncodingStrategy: @unchecked Sendable {
     case iso8601
 
     /// Encodes a String, according to the provided formatter
-    @available(*, deprecated, message: "Use .custom and a Date.FormatStyle instead.")
     case formatted(DateFormatter)
 
     /// Encodes the result of the user-provided function

GRDB/Record/FetchableRecord.swift

@@ -931,9 +931,9 @@ public enum DatabaseDataDecodingStrategy: Sendable {
 ///     }
 public enum DatabaseDateDecodingStrategy: @unchecked Sendable {
     // @unchecked Sendable because of `DateFormatter`, which lost its
-    // `Sendable` conformance with Xcode 16.3. See
+    // `Sendable` conformance with Xcode 16.3 beta. See
     // <https://github.com/swiftlang/swift/issues/78635>.
-    // TODO GRDB8: remove @unchecked when the .formatted case has been removed.
+    // TODO: remove @unchecked when the compiler issue is fixed.
 
     /// The strategy that uses formatting from the Date structure.
     ///
@@ -968,7 +968,6 @@ public enum DatabaseDateDecodingStrategy: @unchecked Sendable {
     case iso8601
 
     /// Decodes a String, according to the provided formatter
-    @available(*, deprecated, message: "Use .custom and a Date.FormatStyle instead.")
     case formatted(DateFormatter)
 
     /// Decodes according to the user-provided function.

Tests/GRDBTests/DatabaseDateDecodingStrategyTests.swift

@@ -26,7 +26,6 @@ private enum StrategyIso8601: StrategyProvider {
     static let strategy: DatabaseDateDecodingStrategy = .iso8601
 }
 
-@available(*, deprecated)
 private enum StrategyFormatted: StrategyProvider {
     static let strategy: DatabaseDateDecodingStrategy = .formatted({
         let formatter = DateFormatter()
@@ -419,7 +418,6 @@ extension DatabaseDateDecodingStrategyTests {
 // MARK: - formatted(DateFormatter)
 
 extension DatabaseDateDecodingStrategyTests {
-    @available(*, deprecated)
     func testFormatted() throws {
         try makeDatabaseQueue().read { db in
             var calendar = Calendar(identifier: .gregorian)

Tests/GRDBTests/DatabaseDateEncodingStrategyTests.swift

@@ -30,7 +30,6 @@ private enum StrategyIso8601: StrategyProvider {
     static let strategy: DatabaseDateEncodingStrategy = .iso8601
 }
 
-@available(*, deprecated)
 private enum StrategyFormatted: StrategyProvider {
     static let strategy: DatabaseDateEncodingStrategy = .formatted({
         let formatter = DateFormatter()
@@ -198,7 +197,6 @@ extension DatabaseDateEncodingStrategyTests {
 // MARK: - formatted(DateFormatter)
 
 extension DatabaseDateEncodingStrategyTests {
-    @available(*, deprecated)
     func testFormatted() throws {
         try testNullEncoding(strategy: StrategyFormatted.self)