Upgrading Spock through Grape does not work

[Vampire]

Before I wrote the comment #534 (review) I'm pretty sure I tested whether this really works and it did.

But right now this does not work anymore.
If you check https://groovyconsole.dev/?g=groovy_4_0&codez=eNpljLEOgjAQhvc-xYUJBhpjcGFyMw4u6gvUcpCG2iPXAzGGd7chcVDH--77v_2BzS3PiDsdB7J9y-aOD-K-Xs_SEmO91VV52pUdE03PstKbrFDuPhALrJb2JnT6MqB1rbNGHIXP_z-sR3E-yYmd0aOJeAwtKWW9iRGuGAVwFgxNhK8ivBRAgy1kkpwsL1YAMLAL4kP-W9QTcky7YrVwTi2pQXjEBBa1qDfqbVcb, it outputs

2.3.0-groovy-4.0

[Vampire]

Ah, no, the case I tried was that it complained about not finding class spock.mock.MockMakers as this is new in 2.4.
Using the Grape added 2.4 in the script's classloader, so the spock.mock.MockMakers class was found, but other than that still the 2.3 classes were used as they are found in the parent classloader. :-(

So instead of "not working anymore" this is now a feature request to either support selecting a Spock version like selecting a Groovy version, or making it work through the Grape.

[Vampire]

That would maybe also make things a bit cleaner as currently environment-wise, because currently you can also access the classe from this project in the script.

[leonard84]

Do you have an implementation suggestion? We want Spock to be available out of the box, without requiring the user to add grapes. We also use some of Spock's classes in the app directly, so relying on the script execution to obtain them will be tricky.

[Vampire]

I did not play with it.
But ScriptCompiler (Spock spec) uses the current context classloader as parent and GroovyShell (other Groovy script) uses GroovyShell's classloader as parent which is the same classloader.

I guess both should just use the system classloader as parent so that neither this project's classes nor the dependencies are promoted to the script context.
Then inject (either to all scripts like now or only to recognized Spock specifications) to the end of the script

@Grab("org.spockframework:spock-core:2.3-groovy-X")
import java.lang.Object

As Grapes follow the non-sense nearest-wins logic of Maven, any earlier defined Grape with Spock wins and could even downgrade Spock to a previous version.
And if there is no Grape with Spock in the script, this last two lines in the script will bring in the 2.3-groovy-X version.

The other functions like getting the version or rendering the AST probably has to be done in the context of those script's class loaders.
For example either have an AST transformer that throws out all code from the Script and adds in the code that renders the AST or gives the version and compile with that or similar.

[Vampire]

It might need a bit effort to operate out the Spock and JUnit Platform stuff so that it is in separate classes that are then executed in the context of the supplied script.
But it should indeed work.
I played a bit around and with this patch (of course needs a bit more sophisticated effort for example an AST transformer instead of regex-replace):

diff --git a/functions/groovy-executor/pom.xml b/functions/groovy-executor/pom.xml
index 1b83ab3..29af0e7 100644
--- a/functions/groovy-executor/pom.xml
+++ b/functions/groovy-executor/pom.xml
@@ -92,7 +92,7 @@
         <dependency>
           <groupId>org.spockframework</groupId>
           <artifactId>spock-core</artifactId>
-          <scope>compile</scope>
+          <scope>provided</scope>
           <exclusions>
             <exclusion>
               <!-- need to exclude here as groovy changed their groupId-->
diff --git a/functions/groovy-executor/src/main/java/gwc/GFunctionExecutor.java b/functions/groovy-executor/src/main/java/gwc/GFunctionExecutor.java
index 924aef6..ad12740 100644
--- a/functions/groovy-executor/src/main/java/gwc/GFunctionExecutor.java
+++ b/functions/groovy-executor/src/main/java/gwc/GFunctionExecutor.java
@@ -69,11 +69,13 @@ public class GFunctionExecutor implements HttpFunction {
     var errorOutput = new StringBuilder();

     OutputRedirector outputRedirector = new OutputRedirector();
+    OutputRedirector spockVersionOutputRedirector = new OutputRedirector();
     Object result = null;
     ExecutionInfo stats = new ExecutionInfo();
     try (var ignore = new MetaClassRegistryGuard();
          var ignore2 = outputRedirector.redirect();
-         var igonre3 = new SystemPropertiesGuard()) {
+         var ignore3 = spockVersionOutputRedirector.redirect();
+         var igonre4 = new SystemPropertiesGuard()) {
       long executionStart = System.currentTimeMillis();
       boolean isSpock = SPOCK_SCRIPT.matcher(inputScriptOrClass).find();
       if ("ast".equalsIgnoreCase(scriptRequest.getAction())) {
@@ -85,6 +87,8 @@ public class GFunctionExecutor implements HttpFunction {
           result = executeGroovyScript(inputScriptOrClass, outputRedirector);
         }
       }
+      executeGroovyScript(inputScriptOrClass.replaceAll("(?m)^(?!import |@Gra[bp]).*+$", "") + "\nprint(org.spockframework.util.SpockReleaseInfo.version)", spockVersionOutputRedirector);
+      stats.setSpockVersion(spockVersionOutputRedirector.getOutput());
       stats.setExecutionTime(System.currentTimeMillis() - executionStart);
     } catch (MultipleCompilationErrorsException e) {
       handleCompilationErrors(errorOutput, e);
@@ -127,7 +131,7 @@ public class GFunctionExecutor implements HttpFunction {
     var binding = new Binding();
     binding.setVariable("out", outputRedirector.getOutPrintStream());
     var shell = new GroovyShell(binding);
-    return shell.evaluate(inputScriptOrClass);
+    return shell.evaluate(inputScriptOrClass + "\n@Grab('org.spockframework:spock-core:2.3-groovy-4.0')\nimport java.lang.Object");
   }

   private Object executeSpock(String inputScriptOrClass) {
diff --git a/functions/groovy-executor/src/main/java/gwc/representations/ExecutionInfo.java b/functions/groovy-executor/src/main/java/gwc/representations/ExecutionInfo.java
index 98e2498..295401e 100644
--- a/functions/groovy-executor/src/main/java/gwc/representations/ExecutionInfo.java
+++ b/functions/groovy-executor/src/main/java/gwc/representations/ExecutionInfo.java
@@ -7,7 +7,7 @@ public class ExecutionInfo {
   private long executionTime = -1;
   private String groovyVersion = GroovySystem.getVersion();

-  private String spockVersion = SpockReleaseInfo.getVersion().toString();
+  private String spockVersion = "<no Spock present>";

   private String javaVersion = System.getProperty("java.version");

I was able to execute

import org.spockframework.util.SpockReleaseInfo
println(SpockReleaseInfo.version)

and get 2.3.0-groovy-4.0 in the output as well as in the "Info" tab.
And I was able to execute

@Grab('org.spockframework:spock-core:2.4-M5-groovy-4.0')
import org.spockframework.util.SpockReleaseInfo
println(SpockReleaseInfo.version)

and get 2.4.0-M5-groovy-4.0 in the output as well as in the "Info" tab.

In the end this could then also be extended to have a Spockversion selector like the Groovy selector as the Spock version is anyway injected into the script as Grape.

For the "Spock execution" variant this needs also the JUnit Platform stuff to be injected into the script, otherwise the JUnit Platform will not find the spock engine as it is in a child classloader.