Experimental: customizable validation

Author: leebyron

src/utilities/TypeInfo.js

@@ -53,15 +53,23 @@ export class TypeInfo {
   _fieldDefStack: Array<?GraphQLFieldDefinition>;
   _directive: ?GraphQLDirective;
   _argument: ?GraphQLArgument;
+  _getFieldDef: typeof getFieldDef;
 
-  constructor(schema: GraphQLSchema) {
+  constructor(
+    schema: GraphQLSchema,
+    // NOTE: this experimental optional second parameter is only needed in order
+    // to support non-spec-compliant codebases. You should never need to use it.
+    // It may disappear in the future.
+    getFieldDefFn?: typeof getFieldDef
+  ) {
     this._schema = schema;
     this._typeStack = [];
     this._parentTypeStack = [];
     this._inputTypeStack = [];
     this._fieldDefStack = [];
     this._directive = null;
     this._argument = null;
+    this._getFieldDef = getFieldDefFn || getFieldDef;
   }
 
   getType(): ?GraphQLOutputType {
@@ -114,7 +122,7 @@ export class TypeInfo {
         var parentType = this.getParentType();
         var fieldDef;
         if (parentType) {
-          fieldDef = getFieldDef(schema, parentType, node);
+          fieldDef = this._getFieldDef(schema, parentType, node);
         }
         this._fieldDefStack.push(fieldDef);
         this._typeStack.push(fieldDef && fieldDef.type);

src/validation/__tests__/harness.js

@@ -292,7 +292,7 @@ var QueryRoot = new GraphQLObjectType({
   })
 });
 
-var defaultSchema = new GraphQLSchema({
+export var testSchema = new GraphQLSchema({
   query: QueryRoot,
   directives: [
     new GraphQLDirective({
@@ -316,11 +316,11 @@ function expectInvalid(schema, rules, queryString, expectedErrors) {
 }
 
 export function expectPassesRule(rule, queryString) {
-  return expectValid(defaultSchema, [ rule ], queryString);
+  return expectValid(testSchema, [ rule ], queryString);
 }
 
 export function expectFailsRule(rule, queryString, errors) {
-  return expectInvalid(defaultSchema, [ rule ], queryString, errors);
+  return expectInvalid(testSchema, [ rule ], queryString, errors);
 }
 
 export function expectPassesRuleWithSchema(schema, rule, queryString, errors) {

src/validation/__tests__/validation.js

@@ -0,0 +1,72 @@
+/**
+ *  Copyright (c) 2015, Facebook, Inc.
+ *  All rights reserved.
+ *
+ *  This source code is licensed under the BSD-style license found in the
+ *  LICENSE file in the root directory of this source tree. An additional grant
+ *  of patent rights can be found in the PATENTS file in the same directory.
+ */
+
+import { describe, it } from 'mocha';
+import { expect } from 'chai';
+import { testSchema } from './harness';
+import { validate, specifiedRules } from '../';
+import { visitUsingRules } from '../validate';
+import { parse } from '../../language';
+import { TypeInfo } from '../../utilities/TypeInfo';
+
+
+function expectValid(schema, queryString) {
+  const errors = validate(schema, parse(queryString));
+  expect(errors).to.deep.equal([], 'Should validate');
+}
+
+describe('Validate: Supports full validation', () => {
+
+  it('validates queries', () => {
+    expectValid(testSchema, `
+      query {
+        catOrDog {
+          ... on Cat {
+            furColor
+          }
+          ... on Dog {
+            isHousetrained
+          }
+        }
+      }
+    `);
+  });
+
+  // NOTE: experimental
+  it('validates using a custom TypeInfo', () => {
+
+    // This TypeInfo will never return a valid field.
+    const typeInfo = new TypeInfo(testSchema, () => null);
+
+    const ast = parse(`
+      query {
+        catOrDog {
+          ... on Cat {
+            furColor
+          }
+          ... on Dog {
+            isHousetrained
+          }
+        }
+      }
+    `);
+
+    const errors = visitUsingRules(
+      testSchema,
+      typeInfo,
+      ast,
+      specifiedRules
+    );
+
+    expect(errors).to.deep.equal([
+      { message: 'Cannot query field "catOrDog" on "QueryRoot".' }
+    ]);
+  });
+
+});

src/validation/validate.js

@@ -58,19 +58,22 @@ export function validate(
     'Schema must be an instance of GraphQLSchema. Also ensure that there are ' +
     'not multiple versions of GraphQL installed in your node_modules directory.'
   );
-  return visitUsingRules(schema, ast, rules || specifiedRules);
+  var typeInfo = new TypeInfo(schema);
+  return visitUsingRules(schema, typeInfo, ast, rules || specifiedRules);
 }
 
 /**
  * This uses a specialized visitor which runs multiple visitors in parallel,
  * while maintaining the visitor skip and break API.
+ *
+ * @internal
  */
-function visitUsingRules(
+export function visitUsingRules(
   schema: GraphQLSchema,
+  typeInfo: TypeInfo,
   documentAST: Document,
   rules: Array<any>
 ): Array<GraphQLError> {
-  var typeInfo = new TypeInfo(schema);
   var context = new ValidationContext(schema, documentAST, typeInfo);
   var errors = [];