Skip to content

Commit 1bc6568

Browse files
authored
monaco-graphql: fix monaco-editor peer dependency version range (#4133)
fix #4132 (comment)
1 parent 9361440 commit 1bc6568

File tree

5 files changed

+16
-3
lines changed

5 files changed

+16
-3
lines changed

.changeset/sixty-zebras-peel.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"monaco-graphql": patch
3+
"@graphiql/react": patch
4+
---
5+
6+
to fix esm.sh example we should pin `monaco-editor` peer dependency to versions `≥ 0.20.0 and < 0.53`, since `monaco-editor@^0.53.0` isn't supported yet with `monaco-graphql`

packages/graphiql-react/src/env.d.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,10 @@ declare module 'monaco-editor/esm/vs/base/common/uri.js' {
2020
declare module 'monaco-editor/esm/vs/editor/common/core/range.js' {
2121
export { Range } from 'monaco-graphql/esm/monaco-editor';
2222
}
23+
24+
declare module 'https://esm.sh/monaco-graphql/esm/graphql.worker.js?worker&deps=monaco-editor@0.52.2' {
25+
type WorkerCtor = typeof import('*?worker').default; // reuse type from vite/client
26+
27+
const workerConstructor: WorkerCtor;
28+
export default workerConstructor;
29+
}

packages/graphiql-react/src/setup-workers/esm.sh.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable import-x/no-unresolved */
22
import JsonWorker from 'https://esm.sh/monaco-editor@0.52.2/esm/vs/language/json/json.worker.js?worker';
3-
import GraphQLWorker from 'https://esm.sh/monaco-graphql/esm/graphql.worker.js?worker';
3+
import GraphQLWorker from 'https://esm.sh/monaco-graphql/esm/graphql.worker.js?worker&deps=monaco-editor@0.52.2';
44
import EditorWorker from 'https://esm.sh/monaco-editor@0.52.2/esm/vs/editor/editor.worker.js?worker';
55

66
globalThis.MonacoEnvironment = {

packages/monaco-graphql/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
},
7979
"peerDependencies": {
8080
"graphql": "^15.5.0 || ^16.0.0 || ^17.0.0",
81-
"monaco-editor": ">= 0.20.0 < 1",
81+
"monaco-editor": ">= 0.20.0 < 0.53",
8282
"prettier": "^2.8.0 || ^3.0.0"
8383
}
8484
}

yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19377,7 +19377,7 @@ __metadata:
1937719377
vscode-languageserver-types: "npm:^3.17.1"
1937819378
peerDependencies:
1937919379
graphql: ^15.5.0 || ^16.0.0 || ^17.0.0
19380-
monaco-editor: ">= 0.20.0 < 1"
19380+
monaco-editor: ">= 0.20.0 < 0.53"
1938119381
prettier: ^2.8.0 || ^3.0.0
1938219382
languageName: unknown
1938319383
linkType: soft

0 commit comments

Comments
 (0)