From cc793a8dce7a2b19733e8246ce9b91d3d55f60a8 Mon Sep 17 00:00:00 2001 From: Miguel de Elias Date: Mon, 1 Dec 2025 18:11:21 -0300 Subject: [PATCH 1/2] chore: update Horizon configuration file for phase 4 --- .../horizon/ignition/configs/migrate.arbitrumOne.json5 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/horizon/ignition/configs/migrate.arbitrumOne.json5 b/packages/horizon/ignition/configs/migrate.arbitrumOne.json5 index 92d88a42d..25b2e5a31 100644 --- a/packages/horizon/ignition/configs/migrate.arbitrumOne.json5 +++ b/packages/horizon/ignition/configs/migrate.arbitrumOne.json5 @@ -27,10 +27,10 @@ "subgraphServiceAddress": "0xb2Bb92d0DE618878E438b55D5846cfecD9301105", // Must be set for step 4 of the migration - "horizonStakingImplementationAddress": "", - "curationImplementationAddress": "", - "rewardsManagerImplementationAddress": "", - "disputeManagerAddress": "", + "horizonStakingImplementationAddress": "0xaA3359434B534dE9964d4e72bE2782b076a1Eb5A", + "curationImplementationAddress": "0xc4Ce508c8fda35C597CC78e3604261110fc4c957", + "rewardsManagerImplementationAddress": "0xBcD7a231eAB1f4667AAbFdb482026f244bfBf101", + "disputeManagerAddress": "0x2FE023a575449AcB698648eD21276293Fa176f96", // Global parameters "maxThawingPeriod": 2419200 From eb08fc50ec381d92352fc41beeb01a84b00028fa Mon Sep 17 00:00:00 2001 From: Miguel de Elias Date: Mon, 1 Dec 2025 18:51:44 -0300 Subject: [PATCH 2/2] fix: escrow get balance when collected over thawing unit test --- .../horizon/test/unit/escrow/getters.t.sol | 24 ++++++++++++++----- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/packages/horizon/test/unit/escrow/getters.t.sol b/packages/horizon/test/unit/escrow/getters.t.sol index 262192125..2d348cab2 100644 --- a/packages/horizon/test/unit/escrow/getters.t.sol +++ b/packages/horizon/test/unit/escrow/getters.t.sol @@ -34,12 +34,24 @@ contract GraphEscrowGettersTest is GraphEscrowTest { uint256 amountDeposit, uint256 amountThawing, uint256 amountCollected - ) public useGateway useDeposit(amountDeposit) { - vm.assume(amountThawing > 0); - vm.assume(amountDeposit > 0); - vm.assume(amountDeposit >= amountThawing); - vm.assume(amountDeposit >= amountCollected); - vm.assume(amountDeposit - amountCollected < amountThawing); + ) public useGateway { + amountThawing = bound(amountThawing, 1, MAX_STAKING_TOKENS); + amountCollected = bound(amountCollected, 1, MAX_STAKING_TOKENS); + + // amountDeposit must be: + // - >= amountThawing (so we can thaw that amount) + // - >= amountCollected (so we can collect that amount) + // - < amountThawing + amountCollected (so that after collecting, balance < thawing) + // - <= MAX_STAKING_TOKENS (consistent with other tests) + uint256 minDeposit = amountThawing > amountCollected ? amountThawing : amountCollected; + uint256 maxDeposit = amountThawing + amountCollected - 1; + if (maxDeposit > MAX_STAKING_TOKENS) { + maxDeposit = MAX_STAKING_TOKENS; + } + vm.assume(minDeposit <= maxDeposit); + amountDeposit = bound(amountDeposit, minDeposit, maxDeposit); + + _depositTokens(users.verifier, users.indexer, amountDeposit); // thaw some funds _thawEscrow(users.verifier, users.indexer, amountThawing);