Commit a461971
authored
Fix lint workflow and issues that were re-introduced (#1254)
* fix(ci): fix lint workflow to match local linting behaviour and fail on warnings
The lint workflow had two critical issues:
1. **Did not fail on warnings**: The workflow used continue-on-error with exit
code capture via $?, but $? was always 0 because continue-on-error prevents
failures. Fixed by checking step outcomes in a final verification step.
2. **Different results than local linting**: CI ran linters from repo root while
local 'pnpm lint' runs per-package scripts from package directories. This
caused Solhint's import-path-check rule to produce false warnings in CI.
Fixed by running Solhint from each package directory using 'pnpm -r exec'.
Additional improvements:
- Use git ls-files instead of globs to only lint tracked files (much faster)
- Exclude Ignition/build artifacts from JSON linting (939 → 102 files, 89% reduction)
- Add --no-warn-ignored to ESLint to suppress ignore pattern warnings
- Add --no-error-on-unmatched-pattern to Prettier to handle symlinks gracefully
- Simplify workflow structure with fewer, clearer steps
Also fixed YAML syntax warning in build-test.yml (removed redundant branches filter).1 parent 4b76a40 commit a461971
File tree
5 files changed
+132
-245
lines changed- .github/workflows
- packages/horizon/scripts/verify-debug
5 files changed
+132
-245
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
| |||
0 commit comments