Skip to content

Commit 4bfb66a

Browse files
committed
Correct test to match chip behaviour, cast inf to quarter is always nan
Summary: !ci_branch_mk2 Reviewers: #popart, #framework_ip_review_-_any_oss_or_third-party_code_use_has_been_approved, kamil.andrzejewski, timp Reviewed By: #popart, #framework_ip_review_-_any_oss_or_third-party_code_use_has_been_approved, kamil.andrzejewski Subscribers: krzysztofk JIRA Issues: POPLAR-487, AFS-320 Differential Revision: https://phabricator.sourcevertex.net/D83185
1 parent 90e6e01 commit 4bfb66a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/unittests/python/popxl/test_fp8_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def test_host_calculate_pow2scale(dtype_from, dtype_to, shape):
125125
[np.array([250.], np.float16), popxl.float8_143, 0, False, np.array([0b01111111], popxl.dtypes.np_dtype_float8_143)],
126126
[np.array([250.], np.float16), popxl.float8_143, 0, True, np.array([0b10000000], popxl.dtypes.np_dtype_float8_143)],
127127
# Test nan_on_overflow for float8_152 + float16.
128-
[np.array([70000.], np.float16), popxl.float8_152, 0, False, np.array([0b01111111], popxl.dtypes.np_dtype_float8_152)],
128+
[np.array([70000.], np.float16), popxl.float8_152, 0, False, np.array([0b10000000], popxl.dtypes.np_dtype_float8_152)],
129129
[np.array([70000.], np.float16), popxl.float8_152, 0, True, np.array([0b10000000], popxl.dtypes.np_dtype_float8_152)],
130130
# Test nan_on_overflow for float8_143 + float32.
131131
[np.array([250.], np.float32), popxl.float8_143, 0, False, np.array([0b01111111], popxl.dtypes.np_dtype_float8_143)],

0 commit comments

Comments
 (0)