datasource: allow mTLS certificate rotation without restarting grafana #113982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tlsClientCertFile and tlsClientKeyFile are set, configure GetClientCertificate to reload the certificate and key on each request. This enables mTLS deployments to rotate certificates without requiring an application restart. Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw
requested review from
andresmgot,
oshirohugo and
toddtreece
and removed request for
a team
|
|
github-actions
bot
added
type/docs
Contributor
|
Again, thank you for your contribution. Replied in detail in grafana/grafana-plugin-sdk-go#1429 (comment). TL;DR; Plugins should not use the file system. |
Contributor
|
Also, perhaps using the approach mentioned here along with the provisioning reload API may be an option for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
When tlsClientCertFile and tlsClientKeyFile are set, configure GetClientCertificate to reload the certificate and key on each request. This enables mTLS deployments to rotate certificates without requiring an application restart.
Why do we need this feature?
mTLS datasources typically use client certificates that are rotated regularly, often with short lifetimes (e.g., a few months or less). Relying on application restarts to pick up new certificates is operationally fragile and doesn’t scale, especially when the restart must be coordinated before expiry.
With this feature, environments such as Kubernetes, where cert-manager handles certificate rotation, can update client certificates. Grafana will load the certificate dynamically.
Who is this feature for?
Whoever uses datasources with mTLS.
Which issue(s) does this PR fix?:
ref. #44296
Special notes for your reviewer:
Requires: grafana/grafana-plugin-sdk-go#1429
Please check that: