-
Notifications
You must be signed in to change notification settings - Fork 29
Description
see https://github.com/grafana/data-sources/issues/50
I believe one of the main places this plugin runs out of memory is in reading responses. My understanding is that this happens in the getSpreadsheetCall.
In an ideal world we could limit how far into a response we read and stop after it hits a certain point (browsers can only render so much at once and I imagine for some customers it's easy to accidentally make a call much larger than intended). I don't see anything in google's golang lib that allows for us to specify a max read or something like that (though it's very possible I missed it somewhere!)
I do think however it should be possible to make these same calls over http directly without google's library and I believe we could have more control in reading responses.
Alternatively we could come up with some kind of limit on cell ranges, but I'm not sure if that would solve the problem as you don't know how much a single cell contains.
Another alternative would be to explore if google's library contains something for previewing response sizes, but I didn't see any there.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status