-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(calendar): resolve type errors #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,11 +14,28 @@ | |
| * limitations under the License. | ||
| */ | ||
| // [START calendar_quickstart] | ||
| /** | ||
| * @typedef {Object} CalendarEventDateTime | ||
| * @property {string} [dateTime] | ||
| * @property {string} [date] | ||
| */ | ||
|
|
||
| /** | ||
| * @typedef {Object} CalendarEvent | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. link to docs for this object |
||
| * @property {string} summary | ||
| * @property {CalendarEventDateTime} start | ||
| */ | ||
|
|
||
| /** | ||
| * Lists 10 upcoming events in the user's calendar. | ||
| * @return {void} | ||
| * @see https://developers.google.com/calendar/api/v3/reference/events/list | ||
| */ | ||
| function listUpcomingEvents() { | ||
| // Add a check for the Calendar advanced service. | ||
| if (!Calendar.Events) { | ||
| throw new Error('Please enable the Calendar advanced service.'); | ||
| } | ||
| const calendarId = 'primary'; | ||
| // Add query parameters in optionalArgs | ||
| const optionalArgs = { | ||
|
|
@@ -33,12 +50,15 @@ function listUpcomingEvents() { | |
| // call Events.list method to list the calendar events using calendarId optional query parameter | ||
| const response = Calendar.Events.list(calendarId, optionalArgs); | ||
| const events = response.items; | ||
| if (events.length === 0) { | ||
| if (!events || events.length === 0) { | ||
| console.log('No upcoming events found'); | ||
| return; | ||
| } | ||
| // Print the calendar events | ||
| for (const event of events) { | ||
| for (const event of /** @type {CalendarEvent[]} */ (events)) { | ||
| if (!event.start) { | ||
| continue; | ||
| } | ||
| let when = event.start.dateTime; | ||
| if (!when) { | ||
| when = event.start.date; | ||
|
|
@@ -47,7 +67,7 @@ function listUpcomingEvents() { | |
| } | ||
| } catch (err) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove unnecessary try/catch |
||
| // TODO (developer) - Handle exception from Calendar API | ||
| console.log('Failed with error %s', err.message); | ||
| console.log('Failed with error %s', /** @type {Error} */ (err).message); | ||
| } | ||
| } | ||
| // [END calendar_quickstart] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link to docs for this object