Skip to content

Commit 999c97b

Browse files
authored
feat(internal/config): add TitleOverride in rust config (#3242)
Add `TitleOverride` in rust module so it can be correctly set to codec.Source. This field is missing when generating google-cloud-firestore. Fixes #3199
1 parent 7324098 commit 999c97b

File tree

5 files changed

+10
-0
lines changed

5 files changed

+10
-0
lines changed

devtools/cmd/migrate-sidekick/main.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,7 @@ func buildModules(path string) ([]*config.RustModule, error) {
502502
includedIds, _ := sidekick.Source["included-ids"].(string)
503503
includeList, _ := sidekick.Source["include-list"].(string)
504504
skippedIds, _ := sidekick.Source["skipped-ids"].(string)
505+
titleOverride, _ := sidekick.Source["title-override"].(string)
505506

506507
hasVeneer, _ := sidekick.Codec["has-veneer"].(string)
507508
includeGrpcOnlyMethods, _ := sidekick.Codec["include-grpc-only-methods"].(string)
@@ -530,6 +531,7 @@ func buildModules(path string) ([]*config.RustModule, error) {
530531
SkippedIds: strToSlice(skippedIds),
531532
Source: sidekick.General.SpecificationSource,
532533
Template: strings.TrimPrefix(templateOverride, "templates/"),
534+
TitleOverride: titleOverride,
533535
})
534536

535537
return nil

devtools/cmd/migrate-sidekick/main_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,6 +411,7 @@ func TestBuildVeneer(t *testing.T) {
411411
SkippedIds: []string{".google.iam.v1.ResourcePolicyMember"},
412412
Source: "google/storage/v2",
413413
Template: "grpc-client",
414+
TitleOverride: "Cloud Firestore API",
414415
},
415416
{
416417
GenerateSetterSamples: false,

devtools/cmd/migrate-sidekick/testdata/build-veneer/success/lib-1/dir-1/.sidekick.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ included-ids = """\
1111
.google.storage.v2.Storage.ListBuckets\
1212
"""
1313
skipped-ids = ".google.iam.v1.ResourcePolicyMember"
14+
title-override = 'Cloud Firestore API'
1415

1516
[codec]
1617
copyright-year = '2025'

internal/config/language.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,9 @@ type RustModule struct {
8787
// Template specifies which generator template to use.
8888
// Valid values: "grpc-client", "http-client", "prost", "convert-prost", "mod".
8989
Template string `yaml:"template"`
90+
91+
// TitleOverride overrides the crate title.
92+
TitleOverride string `yaml:"title_override,omitempty"`
9093
}
9194

9295
// RustCrate contains Rust-specific library configuration.

internal/librarian/internal/rust/codec.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,9 @@ func moduleToSidekickConfig(library *config.Library, module *config.RustModule,
214214
if module.IncludeList != "" {
215215
source["include-list"] = module.IncludeList
216216
}
217+
if module.TitleOverride != "" {
218+
source["title-override"] = module.TitleOverride
219+
}
217220

218221
language := "rust"
219222
if module.Template == "prost" {

0 commit comments

Comments
 (0)