Skip to content

Commit ef63226

Browse files
authored
fix: Enquote column names to not match reserved keywords. (#267)
* chore: Enquote column names to not match reserved keywords. * Linter fix
1 parent 0f69092 commit ef63226

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/langchain_google_cloud_sql_pg/async_vectorstore.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -241,11 +241,11 @@ async def __aadd_embeddings(
241241
# Insert embeddings
242242
for id, content, embedding, metadata in zip(ids, texts, embeddings, metadatas):
243243
metadata_col_names = (
244-
", " + ", ".join(self.metadata_columns)
244+
", " + ", ".join(f'"{col}"' for col in self.metadata_columns)
245245
if len(self.metadata_columns) > 0
246246
else ""
247247
)
248-
insert_stmt = f'INSERT INTO "{self.schema_name}"."{self.table_name}"({self.id_column}, {self.content_column}, {self.embedding_column}{metadata_col_names}'
248+
insert_stmt = f'INSERT INTO "{self.schema_name}"."{self.table_name}"("{self.id_column}", "{self.content_column}", "{self.embedding_column}"{metadata_col_names}'
249249
values = {"id": id, "content": content, "embedding": str(embedding)}
250250
values_stmt = "VALUES (:id, :content, :embedding"
251251

@@ -261,7 +261,9 @@ async def __aadd_embeddings(
261261

262262
# Add JSON column and/or close statement
263263
insert_stmt += (
264-
f", {self.metadata_json_column})" if self.metadata_json_column else ")"
264+
f""", "{self.metadata_json_column}")"""
265+
if self.metadata_json_column
266+
else ")"
265267
)
266268
if self.metadata_json_column:
267269
values_stmt += ", :extra)"

0 commit comments

Comments
 (0)