Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Commit 10cbca8

Browse files
authored
Bug/example missing semicolon (#5)
Fixes example bug that didnt get caught by travis CI New example added in previous PR had a missing semicolon. That went in because building that example wasn't part of the required automation bits. This PR fixes the semicolon and adds that to the automation/Build list.
1 parent 655ea60 commit 10cbca8

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

.travis.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ matrix:
88
os: linux
99
env:
1010
- MATRIX_EVAL="CC=gcc && CXX=g++"
11-
- CXXFLAGS=""
11+
- CXXFLAGS="" # -Werror=strict-aliasing and other GCC bugs
1212
# Latest gcc
1313
- name: Latest gcc7
1414
os: linux
@@ -35,7 +35,7 @@ matrix:
3535
before_install:
3636
- eval "${MATRIX_EVAL}"
3737
- sudo apt-get -qq update
38-
- sudo apt-get install -y graphviz doxygen
38+
- sudo apt-get install -y graphviz doxygen libeigen3-dev
3939
- $CXX --version
4040

4141
script:
@@ -45,5 +45,6 @@ script:
4545
- make examples/trivialvendingmachine
4646
- make examples/fancyvendingmachine
4747
- make examples/beatmachine
48+
- make examples/resuminggraph
4849
- make docs
4950

examples/resuminggraph.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ DetectorGraph::StateSnapshot ReadSnapshot(const DetectorGraph::StateSnapshot& pr
307307
//![main]
308308
int main()
309309
{
310-
DetectorGraph::StateSnapshot primeSnapshot = GetPrimeSnapshot()
310+
DetectorGraph::StateSnapshot primeSnapshot = GetPrimeSnapshot();
311311
DetectorGraph::StateSnapshot resumeSnapshot = ReadSnapshot(primeSnapshot);
312312

313313
ResumingGraph resumingGraph = ResumingGraph(resumeSnapshot);

makefile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,11 @@ examples/robotlocalization:
107107
# file.
108108
$(CXX) $(CPPSTD) $(CXXFLAGS) $(CONFIG) -g -I$(CORE_INCLUDE) -I$(PLATFORM) -I$(UTIL) $(FULL_SRCS) $(PLATFORM_SRCS) $(UTIL_SRCS) examples/robotlocalization.cpp -o robotlocalization.out && ./robotlocalization.out
109109

110+
examples/beatmachine:
111+
# Keeping a separate rule for this example so that we don't run it as it
112+
# takes way too long to run it (2mins!)
113+
$(CXX) $(CPPSTD) $(CXXFLAGS) $(CONFIG) -g -I$(CORE_INCLUDE) -I$(PLATFORM) -I$(UTIL) $(FULL_SRCS) $(PLATFORM_SRCS) $(UTIL_SRCS) examples/beatmachine.cpp -o beatmachine.out
114+
110115
examples/%:
111116
# General Purpose Example building rule.
112117
$(CXX) $(CPPSTD) $(CXXFLAGS) $(CONFIG) -g -I$(CORE_INCLUDE) -I$(PLATFORM) -I$(UTIL) $(FULL_SRCS) $(PLATFORM_SRCS) $(UTIL_SRCS) $@.cpp -o $(@:examples/%=%.out) && ./$(@:examples/%=%.out)

0 commit comments

Comments
 (0)