Skip to content

ignores terminated event when body is empty (DAP protocol violation) #152

@LiHua000

Description

@LiHua000

When cppdap receives a terminated event with an empty body (e.g., {"type":"event","event":"terminated","body":{}}), it ​​silently skips processing​​ the event.

When debugging Python applications using cppdap, the debug adapter correctly sends a terminated event when the application finishes, but with an empty body field. Currently, cppdap silently ignores these events, preventing my application from handling the proper debug session termination.

this is debugpy`s log:

D+00000.049: Server[1] --> {
                 "pydevd_cmd_id": 129, 
                 "seq": 62, 
                 "type": "event", 
                 "event": "terminated", 
                 "body": {}
             }

D+00000.050: /handling #62 event "terminated" from Server[1]/
             Closing Server[1] message stream

D+00000.050: Exiting message loop for channel Server[1]: No more messages

I+00000.051: /handling disconnect from Server[1]/
             Server[1] has disconnected; finalizing Session[1].

I+00000.051: All debug servers disconnected; waiting for remaining sessions...

D+00000.051: /handling disconnect from Server[1]/
             Client[1] <-- {
                 "seq": 30, 
                 "type": "event", 
                 "event": "terminated"
             }

According to the DAP protocol specification, the body field in terminated events is optional and may be empty. cppdap should properly process these events regardless of the body content.

Additionally, I believe that in commit 574190f, while modifications were made to address similar issues, it still fails to properly handle events with empty bodies as intended.

related issue: #81

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions