Use strpos instead of preg to match error: lines.

Jeff Verkoeyen · Jeff Verkoeyen · commit c7855a0bafc6 · 2016-04-07T19:05:44.000-04:00
Reduces overall string processing time by roughly half.
diff --git a/parser/XcodeTestResultParser.php b/parser/XcodeTestResultParser.php
@@ -63,7 +63,7 @@ public function parseTestResults($path, $test_results) {
         continue;
       }
 
-      if (preg_match('/.+?error:/', $line) === 1) {
+      if (strpos($line, 'error:') !== false) {
         $result = new ArcanistUnitTestResult();
         $result->setName('xcode-unit-engine');
         foreach ($this->xcodeargs as $arg) {

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public function parseTestResults($path, $test_results) {`
`63`	`63`	`continue;`
`64`	`64`	`}`
`65`	`65`
`66`		`- if (preg_match('/.+?error:/', $line) === 1) {`
	`66`	`+ if (strpos($line, 'error:') !== false) {`
`67`	`67`	`$result = new ArcanistUnitTestResult();`
`68`	`68`	`$result->setName('xcode-unit-engine');`
`69`	`69`	`foreach ($this->xcodeargs as $arg) {`