Skip to content
This repository was archived by the owner on Sep 7, 2022. It is now read-only.

Commit 426fbaf

Browse files
author
Jeff Verkoeyen
committed
Merge branch 'release-candidate' into stable
2 parents bc4b6d7 + adb4431 commit 426fbaf

File tree

2 files changed

+22
-14
lines changed

2 files changed

+22
-14
lines changed

CHANGELOG.md

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,59 +1,63 @@
1-
## 3.0.4
1+
# 3.0.5
22

3-
* Resolved [issue #3](https://github.com/google/arc-xcode-test-engine/issues/3): Using test engine with Quick testing library gets "Unable to parse line" error. Thanks to [KevM](https://github.com/KevM) for filing.
3+
* Resolved bug where coverage information was being lost for the last file in a coverage report.
44

5-
## 3.0.3
5+
# 3.0.4
6+
7+
* Resolved [issue #3](https://github.com/google/arc-xcode-test-engine/issues/3): Using test engine with Quick testing library gets "Unable to parse line" error. Thanks to [KevM](https://github.com/KevM) for fixing.
8+
9+
# 3.0.3
610

711
* Resolved coverage failure with Xcode 7.3 and newer. Thanks to [aelam](https://github.com/aelam) for filing [#2](https://github.com/google/arc-xcode-test-engine/issues/2).
812

9-
## 3.0.2
13+
# 3.0.2
1014

1115
* Resolves crash caused by referencing the wrong stderr variable. The error was
1216
`Attempt to read from undeclared property XcodeUnitTestEngine::stderr`.
1317

14-
## 3.0.1
18+
# 3.0.1
1519

1620
* If tests fail to build we no longer generate a
1721
`Unhandled Exception ("PhutilTypeMissingParametersException")` exception on Phabricator. We were
1822
not previously providing a name to the ArcanistUnitTestResult instance.
1923

20-
## 3.0.0
24+
# 3.0.0
2125

2226
* Commands now always run from the root directory of the project rather than from the shell's
2327
current working directory. This may be a breaking change.
2428

25-
## 2.1.1
29+
# 2.1.1
2630

2731
* Improved overall test parsing time by approximately 50%.
2832

29-
## 2.1.0
33+
# 2.1.0
3034

3135
* Added a `pre-build` configuration option.
3236

33-
## 2.0.2
37+
# 2.0.2
3438

3539
* Error line detection is now more flexible. Any output line with "error:" will be detected and
3640
bubble up as an error.
3741

38-
## 2.0.1
42+
# 2.0.1
3943

4044
* Better handling of non-unit-test failures, such as CocoaPods getting out of sync.
4145

42-
## 2.0.0
46+
# 2.0.0
4347

4448
* Coverage is now enabled and **reported** unless explicitly disabled with --no-coverage.
4549
* xcodebuild or llvm-cov failures now properly throw exceptions rather than silently continuing.
4650

47-
## 1.1.0
51+
# 1.1.0
4852

4953
* Coverage is now enabled unless explicitly disabled with --no-coverage.
5054

51-
## 1.0.1
55+
# 1.0.1
5256

5357
* Don't run unit tests if no files were provided to the engine and we're not being asked
5458
to run all tests.
5559

56-
## 1.0.0
60+
# 1.0.0
5761

5862
* Initial release.
5963
* Provides `arc unit` and `arc unit --coverage` support for a single xcode project/target

parser/XcodeTestResultParser.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,10 @@ private function parseCoverageResults() {
146146
}
147147
$file []= $line;
148148
}
149+
if ($file && $filename) {
150+
// Commit the hanging file.
151+
$filemap[$filename] = $file;
152+
}
149153

150154
$arccovmap = array();
151155
foreach ($filemap as $filename => $coverage) {

0 commit comments

Comments
 (0)