Skip to content

Commit 9b53776

Browse files
committed
[release] src/goLanguageServer: block until the language client is ready
According to https://github.com/microsoft/vscode-languageserver-node#breaking-changes, we need to wait until the client is actually ready before attempting to make any request including shutdown. Change-Id: Icfa4c9069ad448156794a7d14ba9036a14bdfd55 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/288372 Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> (cherry picked from commit 55b2284) Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/289232
1 parent 33a0c85 commit 9b53776

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/goLanguageServer.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ async function startLanguageServer(ctx: vscode.ExtensionContext, config: Languag
242242
languageServerDisposable = languageClient.start();
243243
totalStartCount++;
244244
ctx.subscriptions.push(languageServerDisposable);
245+
await languageClient.onReady();
245246
return true;
246247
}
247248

0 commit comments

Comments
 (0)