Updated handling of crashed application during test run. (#130)

Author: yunikkk

composer/src/main/kotlin/com/gojuno/composer/Instrumentation.kt

@@ -1,6 +1,8 @@
 package com.gojuno.composer
 
-import com.gojuno.composer.InstrumentationTest.Status.*
+import com.gojuno.composer.InstrumentationTest.Status.Failed
+import com.gojuno.composer.InstrumentationTest.Status.Ignored
+import com.gojuno.composer.InstrumentationTest.Status.Passed
 import rx.Observable
 import java.io.File
 
@@ -61,7 +63,7 @@ private fun String.parseInstrumentationStatusValue(key: String): String = this
         .trim()
 
 private fun String.throwIfError(output: File) = when {
-    contains("INSTRUMENTATION_RESULT: shortMsg=Process crashed") -> {
+    contains("INSTRUMENTATION_RESULT: shortMsg=") -> {
         throw Exception("Application process crashed. Check Logcat output for more details.")
     }
 

composer/src/test/kotlin/com/gojuno/composer/InstrumentationSpec.kt

@@ -1,6 +1,8 @@
 package com.gojuno.composer
 
-import com.gojuno.composer.InstrumentationTest.Status.*
+import com.gojuno.composer.InstrumentationTest.Status.Failed
+import com.gojuno.composer.InstrumentationTest.Status.Ignored
+import com.gojuno.composer.InstrumentationTest.Status.Passed
 import org.assertj.core.api.Assertions.assertThat
 import org.jetbrains.spek.api.Spek
 import org.jetbrains.spek.api.dsl.context
@@ -736,4 +738,22 @@ at android.app.Instrumentation${'$'}InstrumentationThread.run(Instrumentation.ja
             )
         }
     }
+
+    context("read output with crash") {
+
+        val outputFile = fileFromJarResources<InstrumentationSpec>("instrumentation-output-app-crash.txt")
+        val entries by memoized { readInstrumentationOutput(outputFile) }
+        val entriesSubscriber by memoized { TestSubscriber<InstrumentationEntry>() }
+
+        perform {
+            entries.subscribe(entriesSubscriber)
+            entriesSubscriber.awaitTerminalEvent(30, SECONDS)
+        }
+
+        it("emits exception describing issue") {
+            assertThat(entriesSubscriber.onErrorEvents.first()).hasMessage(
+                    "Application process crashed. Check Logcat output for more details."
+            )
+        }
+    }
 })

composer/src/test/resources/instrumentation-output-app-crash.txt

@@ -0,0 +1,12 @@
+INSTRUMENTATION_STATUS: numtests=1
+INSTRUMENTATION_STATUS: stream=
+com.example.test.TestClass:
+INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
+INSTRUMENTATION_STATUS: test=crashTest
+INSTRUMENTATION_STATUS: class=com.example.test.TestClass:
+INSTRUMENTATION_STATUS: current=1
+INSTRUMENTATION_STATUS_CODE: 1
+INSTRUMENTATION_RESULT: shortMsg=java.lang.NullPointerException
+INSTRUMENTATION_RESULT: longMsg=java.lang.NullPointerException: Attempt to invoke virtual method 'void java.util.logging.Logger.log(java.util.logging.Level, java.lang.String, java.lang.Throwable)' on a null object reference
+
+INSTRUMENTATION_CODE: 0