Remove __annonCompField offsets from witness invariants
#1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a point in #1722.
For example, this will produce a witness with invariants containing our fictitious
__annonCompFieldoffsets:./goblint --conf conf/svcomp.json --set ana.specification ../sv-benchmarks/c/properties/unreach-call.prp --set exp.architecture 64bit ../sv-benchmarks/c/intel-tdx-module/tdg_mr_report__expected__cover_entry_havoc_memory.iThese should be skipped in witness invariant generation: we can keep the invariant, but just remove such components in the offsets because the following non-anonymous field is supposed to uniquely determine the actual field.
However, there's still a problem: many LDV tasks are CIL-ed and have such field explicitly. There they must remain, but I'm not sure how to differentiate this.
Maybe we just have to exclude all such invariants, instead of trying to adapt them.