Avoid unused variable warnings in case __ASSERT evaluates to NOP. #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustylocker
force-pushed
the
fix-unused-warnings
branch
from
6631e7a to
279cf82
Compare
sidcha
reviewed
Nov 26, 2025
Member
sidcha
left a comment
sidcha
left a comment
There was a problem hiding this comment.
LGTM, with the exception of the submodule url change.
.gitmodules
Outdated
| [submodule "utils"] | ||
| path = utils | ||
| url = https://github.com/goToMain/c-utils.git | ||
| url = https://github.com/rustylocker/c-utils.git |
Member
There was a problem hiding this comment.
I guess this changes wasn't meant for upstream. Please revert this change.
Author
There was a problem hiding this comment.
You are right! I removed the commit since it wasn't meant for this branch.
rustylocker
force-pushed
the
fix-unused-warnings
branch
from
279cf82 to
20dab9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using
libosdp-rsin Zephyr building with GCC and-Werror -Wall.