Skip to content

Commit 4e2df94

Browse files
committed
fixed bug - removing settings property - closes #49
1 parent 41fa99b commit 4e2df94

File tree

6 files changed

+31
-5
lines changed

6 files changed

+31
-5
lines changed

src/model/Mlayer.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,16 +121,16 @@ export default {
121121
});
122122
},
123123

124-
removeIn:function(layerId,key){
124+
removeIn:function(layerId,prop){
125125
return new Promise((resolve,reject)=>{
126126
if (!layerId) return reject('no layerId');
127127

128-
// clear out key, if is a list (expression), clear out expression
128+
// clear out prop, if is a list (expression), clear out expression
129129

130130
Store.dispatch({
131131
type:'LAYER_REMOVEIN',
132132
layerId:layerId,
133-
prop:key,
133+
prop:prop,
134134
payload:null
135135
});
136136

src/model/Mstyle.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,23 @@ const Mstyle = {
210210
});
211211
},
212212

213+
removeIn:function(prop){
214+
return new Promise((resolve,reject)=>{
215+
if (!prop) return reject('no prop');
216+
217+
// clear out prop, if is a list (expression), clear out expression
218+
219+
Store.dispatch({
220+
type:'STYLE_REMOVEIN',
221+
prop:prop,
222+
payload:null
223+
});
224+
225+
Mstyle.save();
226+
return resolve();
227+
});
228+
},
229+
213230
validate:function(){
214231
return new Promise((resolve,reject)=>{
215232
const errors = validateStyle(this.getJSforMapbox());

src/reducer/Rstyle.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@ export default function(state = iState, action){
1919
});
2020
return setUpdated(style);
2121
}
22+
case 'STYLE_REMOVEIN':{
23+
//console.log('style setIn:',action.key,action.payload);
24+
const style = state.removeIn(['rec',...action.prop]);
25+
return setUpdated(style);
26+
}
2227
case 'STYLE_SETIN':{
2328
//console.log('style setIn:',action.key,action.payload);
2429
const style = state.setIn(action.key,action.payload);

src/view/Vlayer/VlayerEditor.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export default class VlayerEditor extends React.Component {
6969
layerSetIn:(pos,val)=>{
7070
Mlayer.setIn(layer.get('id'),pos,val);
7171
},
72-
layerRemoveIn:(pos)=>{
72+
removeIn:(pos)=>{
7373
Mlayer.removeIn(layer.get('id'),pos);
7474
},
7575

src/view/Vproperty/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export default class Vproperty extends React.Component {
8383
},
8484
remove:()=>{
8585
const pos = property.name.split('.');
86-
handle.layerRemoveIn(pos);
86+
handle.removeIn(pos);
8787
},
8888
dropdownToggle:()=>{
8989
if (this.state.dropdownShown) return this.setState({dropdownShown:false});

src/view/Vsetting/index.jsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ export default class Vsetting extends React.Component {
3939
deleteHide:()=>{
4040
this.setState({deleteShow:false});
4141
},
42+
removeIn:(pos)=>{
43+
//console.log('Mstyle:',Mstyle);
44+
Mstyle.removeIn(pos);
45+
},
4246
focus:(pos)=>{
4347
//console.log('focus:',pos);
4448
this.setState({focus:pos});

0 commit comments

Comments
 (0)