From 4891315326574c981bfaa7a63f35780c6b447c49 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Tue, 19 Aug 2025 09:39:03 -0700 Subject: [PATCH 1/2] Fix some overflows in test --- models/repo/collaboration_test.go | 2 +- modules/templates/util_format_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/models/repo/collaboration_test.go b/models/repo/collaboration_test.go index 7b07dbffdf01b..de02458d00fb0 100644 --- a/models/repo/collaboration_test.go +++ b/models/repo/collaboration_test.go @@ -86,7 +86,7 @@ func TestRepository_ChangeCollaborationAccessMode(t *testing.T) { assert.NoError(t, repo_model.ChangeCollaborationAccessMode(db.DefaultContext, repo, unittest.NonexistentID, perm.AccessModeAdmin)) // Disvard invalid input. - assert.NoError(t, repo_model.ChangeCollaborationAccessMode(db.DefaultContext, repo, 4, perm.AccessMode(unittest.NonexistentID))) + assert.NoError(t, repo_model.ChangeCollaborationAccessMode(db.DefaultContext, repo, 4, perm.AccessMode(-1))) unittest.CheckConsistencyFor(t, &repo_model.Repository{ID: repo.ID}) } diff --git a/modules/templates/util_format_test.go b/modules/templates/util_format_test.go index 13a57c24e26a2..89e42532f96fd 100644 --- a/modules/templates/util_format_test.go +++ b/modules/templates/util_format_test.go @@ -13,6 +13,6 @@ func TestCountFmt(t *testing.T) { assert.Equal(t, "125", countFmt(125)) assert.Equal(t, "1.3k", countFmt(int64(1317))) assert.Equal(t, "21.3M", countFmt(21317675)) - assert.Equal(t, "45.7G", countFmt(45721317675)) + assert.Equal(t, "45.7G", countFmt(int64(45721317675))) assert.Empty(t, countFmt("test")) } From c65d7b11b2ce506baad9288cbf2d3ae33a9e6272 Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Tue, 19 Aug 2025 12:53:18 -0400 Subject: [PATCH 2/2] Apply suggestion Signed-off-by: techknowlogick --- models/repo/collaboration_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/repo/collaboration_test.go b/models/repo/collaboration_test.go index de02458d00fb0..1e0c84092bd88 100644 --- a/models/repo/collaboration_test.go +++ b/models/repo/collaboration_test.go @@ -85,7 +85,7 @@ func TestRepository_ChangeCollaborationAccessMode(t *testing.T) { assert.NoError(t, repo_model.ChangeCollaborationAccessMode(db.DefaultContext, repo, unittest.NonexistentID, perm.AccessModeAdmin)) - // Disvard invalid input. + // Discard invalid input. assert.NoError(t, repo_model.ChangeCollaborationAccessMode(db.DefaultContext, repo, 4, perm.AccessMode(-1))) unittest.CheckConsistencyFor(t, &repo_model.Repository{ID: repo.ID})