-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
add button to export issues to Excel #35313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add button to export issues to Excel #35313
Conversation
|
@tpokorra I noticed you've updated the locales for non-English languages. These will be overwritten during the sync from our translation tool Crowdin. If you'd like to contribute your translations, please visit https://crowdin.com/project/gitea. Please revert the changes done on these files. 🍵 |
d38901f to
1d87056
Compare
|
The button is far too prominent and there should only ever be one primary button on a page indicating the most likely action the user will take. I recommend making a right-aligned "..." button on the right side of "Sort" and putting it in there. Check repo frontpage on how to implement this "..." menu using tippy.js. |
Thanks for the hint @silverwind I guess you are refering to initClonePanelButton in https://github.com/go-gitea/gitea/blob/main/web_src/js/features/repo-common.ts#L133 which uses Tippy. I tried to find the place where I should add that new button. I will have to continue trying to figure this out in the coming days. |
|
I finally got the tippy button to work. I still have a small css issue, but I will fix that. One question: Now I wonder, if the "Export" button should actually be in a ... button right of the filters, or if it should be displayed with the other actions (close, delete, etc), once one or multiple issues are selected? |
2018f3d to
7212c2d
Compare
|
The tippy.js dropdown now works beside the filter. I also implemented the button with the actions, but I don't filter for the selected issues yet. If I would export only the selected issues, I can only export the currently displayed issues. That is probably not what we want. So I tend to drop the export button from the Actions, and just keep the tippy dropdown beside the filter. What do you think, @silverwind ? |
3d9b665 to
93dad9f
Compare
This PR adds a button to the issues list, and when you click on it, the currently displayed issues will be downloaded as an Excel file.
fixes #29906
Screenshot after adding the button "Export to Excel":
Alternatively, perhaps it is better to add the button to the Actions?