Fix scrolling to resolved comment anchors #13343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described on discord, when the window.location.hash refers to a resolved comment then the scroll to functionality does not work. This PR fixes this. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
topic/ui
silverwind
reviewed
Oct 28, 2020
GiteaBot
added
the
lgtm/need 2
silverwind
reviewed
Oct 28, 2020
silverwind
reviewed
Oct 28, 2020
Co-authored-by: silverwind <me@silverwind.io>
silverwind
approved these changes
Oct 29, 2020
Member
silverwind
left a comment
silverwind
left a comment
There was a problem hiding this comment.
Did not test this but change seems benign enough to not cause issues.
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Oct 31, 2020
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #13343 +/- ##
==========================================
- Coverage 42.15% 42.14% -0.01%
==========================================
Files 690 690
Lines 75888 75888
==========================================
- Hits 31987 31984 -3
- Misses 38663 38666 +3
Partials 5238 5238
Continue to review full report at Codecov.
|
Member
|
please send backport :) |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 31, 2020
* Fix scrolling to resolved comment anchors As described on discord, when the window.location.hash refers to a resolved comment then the scroll to functionality does not work. This PR fixes this. Signed-off-by: Andrew Thornton <art27@cantab.net> * Apply suggestions from code review Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
lafriks
pushed a commit
that referenced
this pull request
Oct 31, 2020
* Fix scrolling to resolved comment anchors As described on discord, when the window.location.hash refers to a resolved comment then the scroll to functionality does not work. This PR fixes this. Signed-off-by: Andrew Thornton <art27@cantab.net> * Apply suggestions from code review Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
techknowlogick
added
the
backport/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described on discord, when the window.location.hash refers to a
resolved comment then the scroll to functionality does not work.
This PR fixes this.
Signed-off-by: Andrew Thornton art27@cantab.net