Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Sep 15, 2020

Move APIIFormat convertion of:

  • User
  • Comment
  • Release
  • Attachments
  • CommitStatus

to convert package

@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. pr/wip This PR is not ready for review labels Sep 15, 2020
@6543 6543 added this to the 1.14.0 milestone Sep 15, 2020
@6543
Copy link
Member Author

6543 commented Sep 15, 2020

blocked by #12729

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 15, 2020
@6543

This comment has been minimized.

@6543 6543 force-pushed the refacotr-user-2-apifromat branch from a64cbac to f21103f Compare September 27, 2020 16:05
@6543 6543 force-pushed the refacotr-user-2-apifromat branch from f21103f to e423b5a Compare September 27, 2020 16:21
@6543 6543 force-pushed the refacotr-user-2-apifromat branch from 0c6e6a7 to 9bb5436 Compare September 27, 2020 17:18
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2020

Codecov Report

Merging #12856 into master will increase coverage by 0.01%.
The diff coverage is 79.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12856      +/-   ##
==========================================
+ Coverage   42.49%   42.51%   +0.01%     
==========================================
  Files         672      674       +2     
  Lines       73785    73780       -5     
==========================================
+ Hits        31353    31364      +11     
+ Misses      37361    37345      -16     
  Partials     5071     5071              
Impacted Files Coverage Δ
models/attachment.go 58.51% <ø> (-2.60%) ⬇️
models/commit_status.go 62.06% <ø> (-3.34%) ⬇️
models/issue_comment.go 45.56% <ø> (+1.15%) ⬆️
models/release.go 52.17% <ø> (-5.29%) ⬇️
models/user.go 53.18% <ø> (-0.40%) ⬇️
models/userlist.go 90.38% <ø> (+7.92%) ⬆️
modules/convert/user.go 88.23% <0.00%> (-11.77%) ⬇️
routers/api/v1/repo/issue_subscription.go 30.26% <0.00%> (-1.25%) ⬇️
routers/api/v1/repo/release_attachment.go 0.00% <0.00%> (ø)
routers/repo/issue.go 36.86% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23c128...f06b12c. Read the comment docs.

@6543 6543 removed the pr/wip This PR is not ready for review label Sep 27, 2020
@6543 6543 changed the title [WIP] Refactor: move APIFromat functions into convert package [Refactor] Move APIFromat functions into convert package Sep 27, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 27, 2020
@zeripath zeripath changed the title [Refactor] Move APIFromat functions into convert package [Refactor] Move APIFormat functions into convert package Oct 5, 2020
@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #12856 into master will decrease coverage by 0.00%.
The diff coverage is 79.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12856      +/-   ##
==========================================
- Coverage   42.01%   42.01%   -0.01%     
==========================================
  Files         681      683       +2     
  Lines       75220    75215       -5     
==========================================
- Hits        31604    31599       -5     
  Misses      38451    38451              
  Partials     5165     5165              
Impacted Files Coverage Δ
models/attachment.go 58.51% <ø> (-2.60%) ⬇️
models/commit_status.go 62.06% <ø> (-3.34%) ⬇️
models/issue_comment.go 52.21% <ø> (-0.72%) ⬇️
models/release.go 52.17% <ø> (-5.29%) ⬇️
models/user.go 54.17% <ø> (-0.41%) ⬇️
models/userlist.go 90.38% <ø> (+7.92%) ⬆️
modules/convert/user.go 88.23% <0.00%> (-11.77%) ⬇️
routers/api/v1/repo/issue_subscription.go 30.26% <0.00%> (-1.25%) ⬇️
routers/api/v1/repo/release_attachment.go 0.00% <0.00%> (ø)
routers/repo/issue.go 34.93% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131278f...6c6891e. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 17, 2020
@techknowlogick techknowlogick merged commit d453533 into go-gitea:master Oct 17, 2020
@6543 6543 deleted the refacotr-user-2-apifromat branch October 17, 2020 04:46
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants