minor refactor

silverwind · silverwind · commit d3d32a74e5a1 · 2020-08-03T20:18:49.000+02:00
diff --git a/modules/public/public.go b/modules/public/public.go
@@ -109,14 +109,14 @@ func (opts *Options) handle(ctx *macaron.Context, log *log.Logger, opt *Options)
 		}
 	}
 
-	var f http.File
-	split := commaRe.Split(ctx.Req.Header.Get("Accept-Encoding"), -1)
 	encodings := make(map[string]bool)
-	for i := range split {
-		encodings[split[i]] = true
+	for _, encoding := range commaRe.Split(ctx.Req.Header.Get("Accept-Encoding"), -1) {
+		encodings[encoding] = true
 	}
 
+	var f http.File
 	var err error
+
 	if encodings["br"] {
 		f, err = opt.FileSystem.Open(file + ".br")
 		if f != nil {

Original file line number	Diff line number	Diff line change
`@@ -109,14 +109,14 @@ func (opts Options) handle(ctx macaron.Context, log log.Logger, opt Options)`
`109`	`109`	`}`
`110`	`110`	`}`
`111`	`111`
`112`		`- var f http.File`
`113`		`- split := commaRe.Split(ctx.Req.Header.Get("Accept-Encoding"), -1)`
`114`	`112`	`encodings := make(map[string]bool)`
`115`		`- for i := range split {`
`116`		`- encodings[split[i]] = true`
	`113`	`+ for _, encoding := range commaRe.Split(ctx.Req.Header.Get("Accept-Encoding"), -1) {`
	`114`	`+ encodings[encoding] = true`
`117`	`115`	`}`
`118`	`116`
	`117`	`+ var f http.File`
`119`	`118`	`var err error`
	`119`	`+`
`120`	`120`	`if encodings["br"] {`
`121`	`121`	`f, err = opt.FileSystem.Open(file + ".br")`
`122`	`122`	`if f != nil {`