Remove dependency on gitea binary

Author: kdumontnu

.drone.yml

@@ -528,16 +528,23 @@ services:
       POSTGRES_INITDB_ARGS: --encoding=UTF8 --lc-collate='en_US.UTF-8' --lc-ctype='en_US.UTF-8'
 
 steps:
-  - name: build
-    image: techknowlogick/xgo:go-1.18.x
+  - name: deps-frontend
+    image: node:16
     pull: always
     commands:
-      - curl -sL https://deb.nodesource.com/setup_16.x | bash - && apt-get install -y nodejs
-      - export PATH=$PATH:$GOPATH/bin
-      - make build
-    environment:
-      GOPROXY: https://goproxy.io # proxy.golang.org is blocked in China, this proxy is not
-      TAGS: bindata sqlite sqlite_unlock_notify
+      - make deps-frontend
+
+  - name: build-frontend
+    image: node:16
+    commands:
+      - make frontend
+    depends_on: [deps-frontend]
+
+  - name: deps-backend
+    image: golang:1.18
+    pull: always
+    commands:
+      - make deps-backend
     volumes:
       - name: deps
         path: /go
@@ -562,7 +569,7 @@ steps:
       NO_DEPS_PLAYWRIGHT: 1
       TEST_PGSQL_DBNAME: 'testgitea-e2e'
       NPX_FLAGS: '--yes'
-    depends_on: [build]
+    depends_on: [build-frontend, deps-backend]
     volumes:
       - name: deps
         path: /go

playwright.config.js

@@ -33,7 +33,7 @@ const config = {
   // workers: process.env.CI ? 1 : undefined,
 
   /* Reporter to use. See https://playwright.dev/docs/test-reporters */
-  reporter: process.env.CI ? 'list' : [['list'], ['html', {outputFolder: 'tools/e2e/reports/', open: 'never'}]],
+  reporter: process.env.CI ? 'list' : [['list'], ['html', {outputFolder: 'tests/e2e/reports/', open: 'never'}]],
 
   /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
   use: {

tests/e2e/e2e_test.go

@@ -30,7 +30,7 @@ var c *web.Route
 func TestMain(m *testing.M) {
 	defer log.Close()
 
-	tests.InitTest()
+	tests.InitTest(false)
 	c = routers.NormalRoutes()
 
 	os.Unsetenv("GIT_AUTHOR_NAME")

tests/e2e/example.test.e2e.js

@@ -22,11 +22,13 @@ test('Test Register Form', async ({page}, workerInfo) => {
   await expect(page.locator('.ui.positive.message.flash-success')).toHaveText('Account was successfully created.');
   // Optionally include visual testing
   if (process.env.VISUAL_TEST) {
+    await page.waitForLoadState('networkidle');
     // Mock page/version string
     await page.locator('footer div.ui.left').evaluate((node) => node.innerHTML = 'MOCK');
     await expect(page).toHaveScreenshot({timeout: 20000,
       mask: [
         page.locator('.dashboard-navbar span>img.ui.avatar.image'),
+        page.locator('.ui.dropdown.jump.item.tooltip span>img.ui.avatar.image'),
       ]
     });
   }

tests/integration/integration_test.go

@@ -81,7 +81,7 @@ func TestMain(m *testing.M) {
 	graceful.InitManager(managerCtx)
 	defer cancel()
 
-	tests.InitTest()
+	tests.InitTest(true)
 	c = routers.NormalRoutes()
 
 	// integration test settings...

tests/test_utils.go

@@ -29,20 +29,22 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func InitTest() {
+func InitTest(require_gitea bool) {
 	giteaRoot := base.SetupGiteaRoot()
 	if giteaRoot == "" {
 		fmt.Println("Environment variable $GITEA_ROOT not set")
 		os.Exit(1)
 	}
-	giteaBinary := "gitea"
-	if runtime.GOOS == "windows" {
-		giteaBinary += ".exe"
-	}
-	setting.AppPath = path.Join(giteaRoot, giteaBinary)
-	if _, err := os.Stat(setting.AppPath); err != nil {
-		fmt.Printf("Could not find gitea binary at %s\n", setting.AppPath)
-		os.Exit(1)
+	if require_gitea {
+		giteaBinary := "gitea"
+		if runtime.GOOS == "windows" {
+			giteaBinary += ".exe"
+		}
+		setting.AppPath = path.Join(giteaRoot, giteaBinary)
+		if _, err := os.Stat(setting.AppPath); err != nil {
+			fmt.Printf("Could not find gitea binary at %s\n", setting.AppPath)
+			os.Exit(1)
+		}
 	}
 
 	giteaConf := os.Getenv("GITEA_CONF")