Only return valid stopwatches (#19863)

zeripath · techknowlogick · web-flow · commit 8aaba65eeeb7 · 2022-06-02T10:36:46.000+08:00
Looking through the logs of try.gitea.io I am seeing a number of reports
of being unable to APIformat stopwatches because the issueID is 0. These
are invalid StopWatches and they represent a db inconsistency.

This PR simply stops sending them to the eventsource.

Signed-off-by: Andrew Thornton &lt;art27@cantab.net&gt;

Co-authored-by: techknowlogick &lt;techknowlogick@gitea.io&gt;
diff --git a/models/issue_stopwatch.go b/models/issue_stopwatch.go
@@ -75,7 +75,7 @@ type UserStopwatch struct {
 // GetUIDsAndNotificationCounts between the two provided times
 func GetUIDsAndStopwatch() ([]*UserStopwatch, error) {
 	sws := []*Stopwatch{}
-	if err := db.GetEngine(db.DefaultContext).Find(&sws); err != nil {
+	if err := db.GetEngine(db.DefaultContext).Where("issue_id != 0").Find(&sws); err != nil {
 		return nil, err
 	}
 	if len(sws) == 0 {

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ type UserStopwatch struct {`
`75`	`75`	`// GetUIDsAndNotificationCounts between the two provided times`
`76`	`76`	`func GetUIDsAndStopwatch() ([]*UserStopwatch, error) {`
`77`	`77`	`sws := []*Stopwatch{}`
`78`		`- if err := db.GetEngine(db.DefaultContext).Find(&sws); err != nil {`
	`78`	`+ if err := db.GetEngine(db.DefaultContext).Where("issue_id != 0").Find(&sws); err != nil {`
`79`	`79`	`return nil, err`
`80`	`80`	`}`
`81`	`81`	`if len(sws) == 0 {`