refactor

Author: wxiaoguang

options/locale/locale_en-US.ini

@@ -891,7 +891,6 @@ delete_preexisting = Delete pre-existing files
 delete_preexisting_content = Delete files in %s
 delete_preexisting_success = Deleted unadopted files in %s
 blame_prior = View blame prior to this change
-filter_repo_files_no_matching = No matching files found
 
 transfer.accept = Accept Transfer
 transfer.accept_desc =  Transfer to "%s"
@@ -2285,6 +2284,9 @@ topic.done = Done
 topic.count_prompt = You can not select more than 25 topics
 topic.format_prompt = Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
+find_file.go_to_file = Go to file
+find_file.no_matching = No matching file found
+
 error.csv.too_large = Can't render this file because it is too large.
 error.csv.unexpected = Can't render this file because it contains an unexpected character in line %d and column %d.
 error.csv.invalid_field_count = Can't render this file because it has a wrong number of fields in line %d.
@@ -2976,7 +2978,6 @@ review_dismissed_reason = Reason:
 create_branch = created branch <a href="%[2]s">%[3]s</a> in <a href="%[1]s">%[4]s</a>
 starred_repo = starred <a href="%[1]s">%[2]s</a>
 watched_repo = started watching <a href="%[1]s">%[2]s</a>
-find_file = Go to file
 
 [tool]
 ago = %s ago

routers/api/v1/api.go

@@ -826,7 +826,6 @@ func Routes() *web.Route {
 						Put(reqAdmin(), repo.AddTeam).
 						Delete(reqAdmin(), repo.DeleteTeam)
 				}, reqToken())
-				m.Get("/find/*", context.ReferencesGitRepo(), context.RepoRefForAPI, repo.GetRepoFiles)
 				m.Get("/raw/*", context.ReferencesGitRepo(), context.RepoRefForAPI, reqRepoReader(unit.TypeCode), repo.GetRawFile)
 				m.Get("/media/*", context.ReferencesGitRepo(), context.RepoRefForAPI, reqRepoReader(unit.TypeCode), repo.GetRawFileOrLFS)
 				m.Get("/archive/*", reqRepoReader(unit.TypeCode), repo.GetArchive)

routers/api/v1/repo/find_files.go

@@ -1,4 +1,4 @@
-// Copyright 2021 The Gitea Authors. All rights reserved.
+// Copyright 2022 The Gitea Authors. All rights reserved.
 // Use of this source code is governed by a MIT-style
 // license that can be found in the LICENSE file.
 
@@ -15,22 +15,8 @@ const (
 
 // FindFiles render the page to find repository files
 func FindFiles(ctx *context.Context) {
-	ctx.Data["PageIsFindFiles"] = true
-	ctx.Data["PageIsViewCode"] = true
-
-	branchLink := ctx.Repo.RepoLink + "/src/" + ctx.Repo.BranchNameSubURL()
-	treeLink := branchLink
-
-	if len(ctx.Repo.TreePath) > 0 {
-		treeLink += "/" + ctx.Repo.TreePath
-	}
-
-	ctx.Data["BranchName"] = ctx.Repo.BranchName
-	ctx.Data["OwnerName"] = ctx.Repo.Owner.Name
-	ctx.Data["RepoName"] = ctx.Repo.Repository.Name
-
-	ctx.Data["RepoLink"] = ctx.Repo.RepoLink
-	ctx.Data["TreeLink"] = treeLink
-
+	path := ctx.Params("*")
+	ctx.Data["TreeLink"] = ctx.Repo.RepoLink + "/src/" + path
+	ctx.Data["DataLink"] = ctx.Repo.RepoLink + "/tree-list/" + path
 	ctx.HTML(200, tplFindFiles)
 }

routers/web/repo/find.go

@@ -0,0 +1,53 @@
+// Copyright 2022 The Gitea Authors. All rights reserved.
+// Use of this source code is governed by a MIT-style
+// license that can be found in the LICENSE file.
+
+package repo
+
+import (
+	"code.gitea.io/gitea/modules/base"
+	"code.gitea.io/gitea/modules/context"
+	"code.gitea.io/gitea/modules/git"
+	"github.com/go-enry/go-enry/v2"
+	"net/http"
+)
+
+// TreeList get all files' entries of a repository
+func TreeList(ctx *context.Context) {
+	tree, err := ctx.Repo.Commit.SubTree("/")
+	if err != nil {
+		ctx.ServerError("Repo.Commit.SubTree", err)
+		return
+	}
+
+	entries, err := tree.ListEntriesRecursive()
+	if err != nil {
+		ctx.ServerError("Repo.Commit.SubTree", err)
+		return
+	}
+	entries.CustomSort(base.NaturalSortLess)
+
+	var files []string
+	for _, entry := range entries {
+		if !isExcludedEntry(entry) {
+			files = append(files, entry.Name())
+		}
+	}
+	ctx.JSON(http.StatusOK, files)
+}
+
+func isExcludedEntry(entry *git.TreeEntry) bool {
+	if entry.IsDir() {
+		return true
+	}
+
+	if entry.IsSubModule() {
+		return true
+	}
+
+	if enry.IsVendor(entry.Name()) {
+		return true
+	}
+
+	return false
+}

routers/web/repo/treelist.go

@@ -831,7 +831,12 @@ func RegisterRoutes(m *web.Route) {
 		m.Group("/milestone", func() {
 			m.Get("/{id}", repo.MilestoneIssuesAndPulls)
 		}, reqRepoIssuesOrPullsReader, context.RepoRef())
-		m.Get("/find/*", context.RepoRefByType(context.RepoRefBranch), repo.FindFiles)
+		m.Get("/find/*", repo.FindFiles)
+		m.Group("/tree-list", func() {
+			m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.TreeList)
+			m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.TreeList)
+			m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.TreeList)
+		})
 		m.Get("/compare", repo.MustBeNotEmpty, reqRepoCodeReader, repo.SetEditorconfigIfExists, ignSignIn, repo.SetDiffViewStyle, repo.SetWhitespaceBehavior, repo.CompareDiff)
 		m.Combo("/compare/*", repo.MustBeNotEmpty, reqRepoCodeReader, repo.SetEditorconfigIfExists).
 			Get(ignSignIn, repo.SetDiffViewStyle, repo.SetWhitespaceBehavior, repo.CompareDiff).

routers/web/web.go

@@ -1,32 +1,20 @@
 {{template "base/head" .}}
-<div class="page-content repository file list">
+<div class="page-content repository">
 	{{template "repo/header" .}}
-	<div class="ui container" id="repo-file-find-container">
-		<input type="hidden" id="owner-name" value="{{.OwnerName}}">
-		<input type="hidden" id="repo-name" value="{{.RepoName}}">
-		<input type="hidden" id="branch-name" value="{{.BranchName}}">
-		<input type="hidden" id="tree-link" value="{{.TreeLink}}">
-		<div class="repo-title">
+	<div class="ui container">
+		<div class="df ac">
 			<a href="{{$.RepoLink}}">{{.RepoName}}</a>
 			<span class="mr-3 ml-3">/</span>
-			<input id="repo-file-find-input" type="text" style="border:none;outline:none;" autofocus="autofocus">
+			<div class="ui input f1">
+				<input id="repo-file-find-input" type="text" autofocus data-url-data-link="{{.DataLink}}" data-url-tree-link="{{.TreeLink}}">
+			</div>
 		</div>
-		<table id="repo-find-files-table" class="ui single line table">
+		<table id="repo-find-file-table" class="ui single line table">
 			<tbody>
-			{{/* {{range $entry := .Files}}
-				<tr>
-					<td class="name four wide">
-						<span class="truncate">
-							{{svg (printf "octicon-%s" (EntryIcon $entry))}}
-							<a class="find-file-name" href="{{EscapePound $.TreeLink}}/{{EscapePound $entry.Name}}" title="{{$entry.Name}}">{{$entry.Name}}</a>
-						</span>
-					</td>
-				</tr>
-			{{end}} */}}
 			</tbody>
 		</table>
-		<div id="no-hit-prompt" class="ui row center" style="margin-top: 60px;display:none;">
-			<h3>{{.i18n.Tr "repo.filter_repo_files_no_matching"}}</h3>
+		<div id="repo-find-file-no-result" class="ui row center mt-5" style="display:none;">
+			<h3>{{.i18n.Tr "repo.find_file.no_matching"}}</h3>
 		</div>
 	</div>
 </div>

templates/repo/find/files.tmpl

@@ -74,8 +74,8 @@
 					</div>
 				{{end}}
 				<div class="fitted item mx-0">
-					<a href="{{.BaseRepo.Link}}/find/{{.BranchName | PathEscapeSegments}}">
-						<button id="go-to-file" class="ui compact basic button">{{.i18n.Tr "action.find_file"}}</button>
+					<a href="{{.BaseRepo.Link}}/find/{{.BranchNameSubURL}}">
+						<button id="go-to-file" class="ui compact basic button">{{.i18n.Tr "repo.find_file.go_to_file"}}</button>
 					</a>
 				</div>
 			{{else}}

templates/repo/home.tmpl

@@ -3732,46 +3732,6 @@
         }
       }
     },
-    "/repos/{owner}/{repo}/find/{branchname}": {
-      "get": {
-        "produces": [
-          "application/json"
-        ],
-        "tags": [
-          "repository"
-        ],
-        "summary": "Get all files' entries of a repository",
-        "operationId": "repoFindFiles",
-        "parameters": [
-          {
-            "type": "string",
-            "description": "owner of the repo",
-            "name": "owner",
-            "in": "path",
-            "required": true
-          },
-          {
-            "type": "string",
-            "description": "name of the repo",
-            "name": "repo",
-            "in": "path",
-            "required": true
-          },
-          {
-            "type": "string",
-            "description": "branch name of the repo",
-            "name": "branchname",
-            "in": "path",
-            "required": true
-          }
-        ],
-        "responses": {
-          "200": {
-            "description": "success"
-          }
-        }
-      }
-    },
     "/repos/{owner}/{repo}/forks": {
       "get": {
         "produces": [