clean code

Author: kerwin612

routers/web/repo/setting/webhook.go

@@ -121,7 +121,7 @@ func checkHookType(ctx *context.Context) string {
 // WebhooksNew render creating webhook page
 func WebhooksNew(ctx *context.Context) {
 	ctx.Data["Title"] = ctx.Tr("repo.settings.add_webhook")
-	
+
 	// Create a new webhook with default meta settings
 	newWebhook := &webhook.Webhook{HookEvent: &webhook_module.HookEvent{}}
 	// Initialize meta settings with default values
@@ -215,7 +215,7 @@ func createWebhook(ctx *context.Context, params webhookParams) {
 	ctx.Data["Title"] = ctx.Tr("repo.settings.add_webhook")
 	ctx.Data["PageIsSettingsHooks"] = true
 	ctx.Data["PageIsSettingsHooksNew"] = true
-	
+
 	// Create a webhook with default meta settings for template rendering
 	newWebhook := &webhook.Webhook{HookEvent: &webhook_module.HookEvent{}}
 	if err := newWebhook.SetMetaSettings(webhook.DefaultMetaSettings()); err != nil {

web_src/js/features/repo-settings-webhook.ts

@@ -2,31 +2,30 @@
  * Webhook settings functionality
  */
 
-function toggleLimitField(fieldName: string, enabled: boolean): void {
-  const field = document.querySelector<HTMLInputElement>(`input[name="${fieldName}"]`);
-  if (field) {
-    field.disabled = !enabled;
-  }
+import {toggleElemClass} from '../utils/dom.ts';
+
+function setupOptimizationToggle(enableFieldName: string, limitFieldName: string): void {
+  const enableCheckbox = document.querySelector<HTMLInputElement>(`input[name="${enableFieldName}"]`);
+  if (!enableCheckbox) return;
+
+  enableCheckbox.addEventListener('change', (e) => {
+    const target = e.target as HTMLInputElement;
+    const limitField = document.querySelector<HTMLInputElement>(`input[name="${limitFieldName}"]`);
+    if (limitField) {
+      limitField.disabled = !target.checked;
+      // Use toggleElemClass to show/hide the limit field container
+      const limitFieldContainer = limitField.closest('.field');
+      if (limitFieldContainer) {
+        toggleElemClass(limitFieldContainer, 'tw-hidden', !target.checked);
+      }
+    }
+  });
 }
 
 export function initRepoSettingsWebhook(): void {
   if (!document.querySelector('.page-content.repository.settings.webhook')) return;
 
-  // Add event listeners for payload optimization checkboxes
-  const filesEnableCheckbox = document.querySelector<HTMLInputElement>('input[name="payload_optimization_files_enable"]');
-  const commitsEnableCheckbox = document.querySelector<HTMLInputElement>('input[name="payload_optimization_commits_enable"]');
-
-  if (filesEnableCheckbox) {
-    filesEnableCheckbox.addEventListener('change', (e) => {
-      const target = e.target as HTMLInputElement;
-      toggleLimitField('payload_optimization_files_limit', target.checked);
-    });
-  }
-
-  if (commitsEnableCheckbox) {
-    commitsEnableCheckbox.addEventListener('change', (e) => {
-      const target = e.target as HTMLInputElement;
-      toggleLimitField('payload_optimization_commits_limit', target.checked);
-    });
-  }
+  // Setup payload optimization toggles
+  setupOptimizationToggle('payload_optimization_files_enable', 'payload_optimization_files_limit');
+  setupOptimizationToggle('payload_optimization_commits_enable', 'payload_optimization_commits_limit');
 }