Skip to content

Don't return NSXMLDTD objects #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
williameveretteggplant wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −2
Open

Don't return NSXMLDTD objects #547

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
709d536
Don't return NSXMLDTD objects
williameveretteggplant Oct 10, 2025
428696c
Revert "Don't return NSXMLDTD objects"
williameveretteggplant Oct 15, 2025
e81cd97
Don't return NSXMLDTD object
williameveretteggplant Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/NSXMLNode.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,8 @@ + (NSXMLNode *) _objectForNode: (xmlNodePtr)node
kind = NSXMLDTDKind;
break;
case XML_ATTRIBUTE_DECL:
cls = [NSXMLDTDNode class];
kind = NSXMLAttributeDeclarationKind;
// DTD nodes are not handled correctly and cause crashes. This just ignores them until a proper way to deal with them is found
return nil;
break;
case XML_ELEMENT_DECL:
cls = [NSXMLDTDNode class];
Expand Down