Skip to content

Code Review #1

@boatcoder

Description

@boatcoder
if hasattr(request, 'cparam'):
        for k, v in request.cparam.items():
            params.append('{0}={1}'.format(k, v))

Doesn't take into account potential need for v to urlencoded....

Might be better to clone the QueryDict that is GET with mutable=True and update the QueryDict and urlencode the final result. This would also allow you to replace params vs just append params to the end of the URL....

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions