Remove use of 'any' type in 12 files (#58540)

Author: heiskr

src/app/lib/server-context-utils.ts

@@ -3,12 +3,13 @@ import { extractVersionFromPath } from '@/app/lib/version-utils'
 import { getUIDataMerged } from '@/data-directory/lib/get-data'
 import { type LanguageCode } from '@/languages/lib/languages'
 import { createTranslationFunctions, translate } from '@/languages/lib/translation-utils'
+import type { UIStrings } from '@/frame/components/context/MainContext'
 
 export interface ServerAppRouterContext {
   currentLanguage: LanguageCode
   currentVersion: string
   sitename: string
-  site: { data: { ui: any } }
+  site: { data: { ui: UIStrings } }
 }
 
 /**

src/assets/middleware/dynamic-assets.ts

@@ -144,7 +144,11 @@ export default async function dynamicAssets(
       assetCacheControl(res)
       return res.type('image/webp').send(buffer)
     } catch (catchError) {
-      if (catchError instanceof Error && (catchError as any).code !== 'ENOENT') {
+      if (
+        catchError instanceof Error &&
+        'code' in catchError &&
+        (catchError as NodeJS.ErrnoException).code !== 'ENOENT'
+      ) {
         throw catchError
       }
     }

src/content-linter/lib/linting-rules/journey-tracks-guide-path-exists.ts

@@ -52,22 +52,26 @@ export const journeyTracksGuidePathExists = {
   description: 'Journey track guide paths must reference existing content files',
   tags: ['frontmatter', 'journey-tracks'],
   function: (params: RuleParams, onError: RuleErrorCallback) => {
-    // Using any for frontmatter as it's a dynamic YAML object with varying properties
-    const fm: any = getFrontmatter(params.lines)
-    if (!fm || !fm.journeyTracks || !Array.isArray(fm.journeyTracks)) return
-    if (!fm.layout || fm.layout !== 'journey-landing') return
+    // Using unknown for frontmatter as it's a dynamic YAML object with varying properties
+    const fm: unknown = getFrontmatter(params.lines)
+    if (!fm || typeof fm !== 'object' || !('journeyTracks' in fm)) return
+    const fmObj = fm as Record<string, unknown>
+    if (!Array.isArray(fmObj.journeyTracks)) return
+    if (!('layout' in fmObj) || fmObj.layout !== 'journey-landing') return
 
     const journeyTracksLine = params.lines.find((line: string) => line.startsWith('journeyTracks:'))
 
     if (!journeyTracksLine) return
 
     const journeyTracksLineNumber = params.lines.indexOf(journeyTracksLine) + 1
 
-    for (let trackIndex = 0; trackIndex < fm.journeyTracks.length; trackIndex++) {
-      const track: any = fm.journeyTracks[trackIndex]
-      if (track.guides && Array.isArray(track.guides)) {
-        for (let guideIndex = 0; guideIndex < track.guides.length; guideIndex++) {
-          const guide: string = track.guides[guideIndex]
+    for (let trackIndex = 0; trackIndex < fmObj.journeyTracks.length; trackIndex++) {
+      const track: unknown = fmObj.journeyTracks[trackIndex]
+      if (!track || typeof track !== 'object' || !('guides' in track)) continue
+      const trackObj = track as Record<string, unknown>
+      if (trackObj.guides && Array.isArray(trackObj.guides)) {
+        for (let guideIndex = 0; guideIndex < trackObj.guides.length; guideIndex++) {
+          const guide: string = trackObj.guides[guideIndex]
           if (typeof guide === 'string') {
             if (!isValidGuidePath(guide, params.name)) {
               addError(

src/content-linter/lib/linting-rules/journey-tracks-unique-ids.ts

@@ -10,9 +10,11 @@ export const journeyTracksUniqueIds = {
   tags: ['frontmatter', 'journey-tracks', 'unique-ids'],
   function: function GHD060(params: RuleParams, onError: RuleErrorCallback) {
     // Using any for frontmatter as it's a dynamic YAML object with varying properties
-    const fm: any = getFrontmatter(params.lines)
-    if (!fm || !fm.journeyTracks || !Array.isArray(fm.journeyTracks)) return
-    if (!fm.layout || fm.layout !== 'journey-landing') return
+    const fm: unknown = getFrontmatter(params.lines)
+    if (!fm || typeof fm !== 'object' || !('journeyTracks' in fm)) return
+    const fmObj = fm as Record<string, unknown>
+    if (!Array.isArray(fmObj.journeyTracks)) return
+    if (!('layout' in fmObj) || fmObj.layout !== 'journey-landing') return
 
     // Find the base journeyTracks line
     const journeyTracksLine: string | undefined = params.lines.find((line: string) =>
@@ -37,7 +39,7 @@ export const journeyTracksUniqueIds = {
           trackCount++
 
           // Stop once we've found all the tracks we know exist
-          if (fm && fm.journeyTracks && trackCount >= fm.journeyTracks.length) {
+          if (Array.isArray(fmObj.journeyTracks) && trackCount >= fmObj.journeyTracks.length) {
             break
           }
         }
@@ -48,11 +50,12 @@ export const journeyTracksUniqueIds = {
     // Track seen journey track IDs and line number for error reporting
     const seenIds = new Map<string, number>()
 
-    for (let index = 0; index < fm.journeyTracks.length; index++) {
-      const track: any = fm.journeyTracks[index]
-      if (!track || typeof track !== 'object') continue
+    for (let index = 0; index < fmObj.journeyTracks.length; index++) {
+      const track: unknown = fmObj.journeyTracks[index]
+      if (!track || typeof track !== 'object' || !('id' in track)) continue
 
-      const trackId = track.id
+      const trackObj = track as Record<string, unknown>
+      const trackId = trackObj.id
       if (!trackId || typeof trackId !== 'string') continue
 
       const currentLineNumber = getTrackLineNumber(index)

src/content-render/liquid/tool.ts

@@ -47,26 +47,27 @@ export const Tool = {
   type: 'block' as const,
   tagName: '',
   // Liquid template objects don't have TypeScript definitions
-  templates: [] as any[],
+  templates: [] as unknown[],
 
   // tagToken and remainTokens are Liquid internal types without TypeScript definitions
-  parse(tagToken: any, remainTokens: any) {
-    this.tagName = tagToken.name
+  parse(tagToken: unknown, remainTokens: unknown) {
+    const token = tagToken as { name: string; getText: () => string }
+    this.tagName = token.name
     this.templates = []
 
     const stream = this.liquid.parser.parseStream(remainTokens)
     stream
       .on(`tag:end${this.tagName}`, () => stream.stop())
       // tpl is a Liquid template object without TypeScript definitions
-      .on('template', (tpl: any) => this.templates.push(tpl))
+      .on('template', (tpl: unknown) => this.templates.push(tpl))
       .on('end', () => {
-        throw new Error(`tag ${tagToken.getText()} not closed`)
+        throw new Error(`tag ${token.getText()} not closed`)
       })
     stream.start()
   },
 
   // scope is a Liquid scope object, Generator yields/returns Liquid template values - no TypeScript definitions available
-  *render(scope: any): Generator<any, any, any> {
+  *render(scope: unknown): Generator<unknown, unknown, unknown> {
     const output = yield this.liquid.renderer.renderTemplates(this.templates, scope)
     return yield this.liquid.parseAndRender(template, {
       tagName: this.tagName,

src/content-render/scripts/all-documents/lib.ts

@@ -1,6 +1,6 @@
 import type { Response } from 'express'
 
-import type { ExtendedRequest, Page } from '@/types'
+import type { ExtendedRequest, Page, Context } from '@/types'
 import contextualize from '@/frame/middleware/context/context'
 import features from '@/versions/middleware/features'
 import shortVersions from '@/versions/middleware/short-versions'
@@ -55,7 +55,7 @@ export async function allDocuments(options: Options): Promise<AllDocument[]> {
       const next = () => {}
       const res = {}
       const pagePath = permalink.href
-      const context: any = {}
+      const context: Partial<Context> = {}
       const req = {
         path: pagePath,
         language: permalink.languageCode,
@@ -68,7 +68,7 @@ export async function allDocuments(options: Options): Promise<AllDocument[]> {
       await contextualize(req as ExtendedRequest, res as Response, next)
       await shortVersions(req as ExtendedRequest, res as Response, next)
       req.context.page = page
-      features(req as any, res as any, next)
+      features(req as ExtendedRequest, res as Response, next)
 
       const title = fields.includes('title')
         ? await page.renderProp('title', req.context, { textOnly: true })

src/events/tests/middleware.ts

@@ -6,7 +6,7 @@ import { contentTypesEnum } from '@/frame/lib/frontmatter'
 describe('POST /events', () => {
   vi.setConfig({ testTimeout: 60 * 1000 })
 
-  async function checkEvent(data: any) {
+  async function checkEvent(data: unknown) {
     if (!Array.isArray(data)) {
       data = [data]
     }

src/frame/tests/pages.ts

@@ -60,14 +60,15 @@ describe('pages module', () => {
 
       // Page objects have dynamic properties from chain/lodash that aren't fully typed
       for (const page of englishPages) {
-        for (const redirect of (page as any).redirect_from) {
-          for (const version of (page as any).applicableVersions) {
+        const pageObj = page as Record<string, unknown>
+        for (const redirect of pageObj.redirect_from as string[]) {
+          for (const version of pageObj.applicableVersions as string[]) {
             const versioned = removeFPTFromPath(path.posix.join('/', version, redirect))
-            versionedRedirects.push({ path: versioned, file: (page as any).fullPath })
+            versionedRedirects.push({ path: versioned, file: pageObj.fullPath as string })
             if (!redirectToFiles.has(versioned)) {
               redirectToFiles.set(versioned, new Set<string>())
             }
-            redirectToFiles.get(versioned)!.add((page as any).fullPath)
+            redirectToFiles.get(versioned)!.add(pageObj.fullPath as string)
           }
         }
       }
@@ -97,7 +98,7 @@ describe('pages module', () => {
             page.languageCode === 'en' && // only check English
             !page.relativePath.includes('index.md') && // ignore TOCs
             // Page class has dynamic frontmatter properties like 'allowTitleToDifferFromFilename' not in type definition
-            !(page as any).allowTitleToDifferFromFilename && // ignore docs with override
+            !(page as Record<string, unknown>).allowTitleToDifferFromFilename && // ignore docs with override
             slugger.slug(decode(page.title)) !== path.basename(page.relativePath, '.md') &&
             slugger.slug(decode(page.shortTitle || '')) !== path.basename(page.relativePath, '.md')
           )
@@ -129,7 +130,7 @@ describe('pages module', () => {
       const frontmatterErrors = chain(pages)
         // .filter(page => page.languageCode === 'en')
         // Page class has dynamic error properties like 'frontmatterErrors' not in type definition
-        .map((page) => (page as any).frontmatterErrors)
+        .map((page) => (page as Record<string, unknown>).frontmatterErrors)
         .filter(Boolean)
         .flatten()
         .value()
@@ -149,7 +150,7 @@ describe('pages module', () => {
 
       for (const page of pages) {
         // Page class has dynamic properties like 'raw' markdown not in type definition
-        const markdown = (page as any).raw
+        const markdown = (page as Record<string, unknown>).raw as string
         if (!patterns.hasLiquid.test(markdown)) continue
         try {
           await liquid.parse(markdown)

src/languages/tests/translation-error-comments.ts

@@ -8,9 +8,20 @@ import {
 import { TitleFromAutotitleError } from '@/content-render/unified/rewrite-local-links'
 import Page from '@/frame/lib/page'
 
+// Type aliases for error objects with token information
+type ErrorWithToken = Error & { token: { file: string; getPosition: () => number[] } }
+type ErrorWithTokenNoFile = Error & { token: { getPosition: () => number[] } }
+type ErrorWithTokenNoPosition = Error & { token: { file: string } }
+type ErrorWithTokenAndOriginal = Error & {
+  token: { file: string; getPosition: () => number[] }
+  originalError: Error
+}
+
 describe('Translation Error Comments', () => {
   // Mock renderContent for integration tests
-  let mockRenderContent: MockedFunction<(template: string, context: any) => string>
+  let mockRenderContent: MockedFunction<
+    (template: string, context: Record<string, unknown>) => string
+  >
 
   beforeEach(() => {
     mockRenderContent = vi.fn()
@@ -26,7 +37,7 @@ describe('Translation Error Comments', () => {
       test('includes all fields when token information is available', () => {
         const error = new Error("Unknown tag 'badtag', line:1, col:3")
         error.name = 'ParseError'
-        ;(error as any).token = {
+        ;(error as unknown as ErrorWithToken).token = {
           file: '/content/test/article.md',
           getPosition: () => [1, 3],
         }
@@ -48,11 +59,13 @@ describe('Translation Error Comments', () => {
       test('includes original error message when available', () => {
         const error = new Error("Unknown variable 'variables.nonexistent.value'")
         error.name = 'RenderError'
-        ;(error as any).token = {
+        ;(error as unknown as ErrorWithToken).token = {
           file: '/content/test/intro.md',
           getPosition: () => [3, 15],
         }
-        ;(error as any).originalError = new Error('Variable not found: variables.nonexistent.value')
+        ;(error as unknown as ErrorWithTokenAndOriginal).originalError = new Error(
+          'Variable not found: variables.nonexistent.value',
+        )
 
         const result = createTranslationFallbackComment(error, 'rawIntro')
 
@@ -67,7 +80,7 @@ describe('Translation Error Comments', () => {
       test('falls back to main error message when no originalError', () => {
         const error = new Error('Main error message')
         error.name = 'RenderError'
-        ;(error as any).token = {
+        ;(error as unknown as ErrorWithToken).token = {
           file: '/content/test.md',
           getPosition: () => [1, 1],
         }
@@ -82,7 +95,7 @@ describe('Translation Error Comments', () => {
       test('includes tokenization error details', () => {
         const error = new Error('Unexpected token, line:1, col:10')
         error.name = 'TokenizationError'
-        ;(error as any).token = {
+        ;(error as unknown as ErrorWithToken).token = {
           file: '/content/test/page.md',
           getPosition: () => [1, 10],
         }
@@ -152,7 +165,7 @@ describe('Translation Error Comments', () => {
       test('handles error with token but no file', () => {
         const error = new Error('Error message')
         error.name = 'ParseError'
-        ;(error as any).token = {
+        ;(error as unknown as ErrorWithTokenNoFile).token = {
           // No file property
           getPosition: () => [5, 10],
         }
@@ -167,7 +180,7 @@ describe('Translation Error Comments', () => {
       test('handles error with token but no getPosition method', () => {
         const error = new Error('Error message')
         error.name = 'ParseError'
-        ;(error as any).token = {
+        ;(error as unknown as ErrorWithTokenNoPosition).token = {
           file: '/content/test.md',
           // No getPosition method
         }
@@ -246,7 +259,7 @@ describe('Translation Error Comments', () => {
       test('comment format is valid HTML', () => {
         const error = new Error('Test error')
         error.name = 'ParseError'
-        ;(error as any).token = {
+        ;(error as unknown as ErrorWithToken).token = {
           file: '/content/test.md',
           getPosition: () => [1, 1],
         }
@@ -264,7 +277,7 @@ describe('Translation Error Comments', () => {
       test('contains all required fields when available', () => {
         const error = new Error('Detailed error message')
         error.name = 'RenderError'
-        ;(error as any).token = {
+        ;(error as unknown as ErrorWithToken).token = {
           file: '/content/detailed-test.md',
           getPosition: () => [42, 15],
         }
@@ -283,7 +296,7 @@ describe('Translation Error Comments', () => {
       test('maintains consistent field order', () => {
         const error = new Error('Test message')
         error.name = 'ParseError'
-        ;(error as any).token = {
+        ;(error as unknown as ErrorWithToken).token = {
           file: '/content/test.md',
           getPosition: () => [1, 1],
         }
@@ -320,18 +333,20 @@ describe('Translation Error Comments', () => {
         }
 
         // Mock renderContent to simulate error for Japanese, success for English
-        mockRenderContent.mockImplementation((template: string, innerContext: any) => {
-          if (innerContext.currentLanguage !== 'en' && template.includes('badtag')) {
-            const error = new Error("Unknown tag 'badtag'")
-            error.name = 'ParseError'
-            ;(error as any).token = {
-              file: '/content/test.md',
-              getPosition: () => [1, 5],
+        mockRenderContent.mockImplementation(
+          (template: string, innerContext: Record<string, unknown>) => {
+            if (innerContext.currentLanguage !== 'en' && template.includes('badtag')) {
+              const error = new Error("Unknown tag 'badtag'")
+              error.name = 'ParseError'
+              ;(error as unknown as ErrorWithToken).token = {
+                file: '/content/test.md',
+                getPosition: () => [1, 5],
+              }
+              throw error
             }
-            throw error
-          }
-          return innerContext.currentLanguage === 'en' ? 'English Title' : template
-        })
+            return innerContext.currentLanguage === 'en' ? 'English Title' : template
+          },
+        )
 
         const result = await renderContentWithFallback(mockPage, 'rawTitle', context)
 
@@ -357,14 +372,16 @@ describe('Translation Error Comments', () => {
           },
         }
 
-        mockRenderContent.mockImplementation((template: string, innerContext: any) => {
-          if (innerContext.currentLanguage !== 'en' && template.includes('badtag')) {
-            const error = new Error("Unknown tag 'badtag'")
-            error.name = 'ParseError'
-            throw error
-          }
-          return 'English Title'
-        })
+        mockRenderContent.mockImplementation(
+          (template: string, innerContext: Record<string, unknown>) => {
+            if (innerContext.currentLanguage !== 'en' && template.includes('badtag')) {
+              const error = new Error("Unknown tag 'badtag'")
+              error.name = 'ParseError'
+              throw error
+            }
+            return 'English Title'
+          },
+        )
 
         const result = await renderContentWithFallback(mockPage, 'rawTitle', context, {
           textOnly: true,
@@ -384,7 +401,7 @@ describe('Translation Error Comments', () => {
         const failingCallable = async () => {
           const error = new Error("Unknown variable 'variables.bad'")
           error.name = 'RenderError'
-          ;(error as any).token = {
+          ;(error as unknown as ErrorWithToken).token = {
             file: '/content/article.md',
             getPosition: () => [10, 20],
           }