Remove 'any' types from 14 files (#58716)

heiskr · web-flow · commit 13178f01838f · 2025-12-10T16:07:04.000Z
diff --git a/src/codeql-cli/scripts/sync.ts b/src/codeql-cli/scripts/sync.ts
@@ -29,7 +29,7 @@ async function main() {
     includeBasePath: true,
     globs: ['**/*.md'],
   })
-  const cliMarkdownContents: Record<string, { data: any; content: string }> = {}
+  const cliMarkdownContents: Record<string, { data: Record<string, unknown>; content: string }> = {}
 
   for (const file of markdownFiles) {
     const sourceContent = await readFile(file, 'utf8')
diff --git a/src/content-linter/lib/linting-rules/ctas-schema.ts b/src/content-linter/lib/linting-rules/ctas-schema.ts
@@ -105,15 +105,16 @@ export const ctasSchema: Rule = {
             for (const error of errors) {
               let message = ''
               if (error.keyword === 'required') {
-                message = `Missing required parameter: ${(error.params as any)?.missingProperty}`
+                message = `Missing required parameter: ${(error.params as { missingProperty?: string })?.missingProperty}`
               } else if (error.keyword === 'enum') {
                 const paramName = error.instancePath.substring(1)
                 // Get the actual invalid value from refParams and allowed values from params
                 const invalidValue = refParams[paramName]
-                const allowedValues = (error.params as any)?.allowedValues || []
+                const allowedValues =
+                  (error.params as { allowedValues?: unknown[] })?.allowedValues || []
                 message = `Invalid value for ${paramName}: "${invalidValue}". Valid values are: ${allowedValues.join(', ')}`
               } else if (error.keyword === 'additionalProperties') {
-                message = `Unexpected parameter: ${(error.params as any)?.additionalProperty}`
+                message = `Unexpected parameter: ${(error.params as { additionalProperty?: string })?.additionalProperty}`
               } else {
                 message = `CTA URL validation error: ${error.message}`
               }
diff --git a/src/content-linter/lib/linting-rules/link-punctuation.ts b/src/content-linter/lib/linting-rules/link-punctuation.ts
@@ -3,31 +3,39 @@ import type { RuleParams, RuleErrorCallback, Rule } from '../../types'
 
 import { doesStringEndWithPeriod, getRange, isStringQuoted } from '../helpers/utils'
 
+// Minimal type for markdownit tokens used in this rule
+interface MarkdownToken {
+  children?: MarkdownToken[]
+  line?: string
+  type?: string
+  content?: string
+  lineNumber?: number
+}
+
 export const linkPunctuation: Rule = {
   names: ['GHD001', 'link-punctuation'],
   description: 'Internal link titles must not contain punctuation',
   tags: ['links', 'url'],
   parser: 'markdownit',
   function: (params: RuleParams, onError: RuleErrorCallback) => {
-    // Using 'any' type for token as markdownlint-rule-helpers doesn't provide TypeScript types
-    filterTokens(params, 'inline', (token: any) => {
+    filterTokens(params, 'inline', (token: MarkdownToken) => {
       const { children, line } = token
       let inLink = false
-      for (const child of children) {
+      for (const child of children || []) {
         if (child.type === 'link_open') {
           inLink = true
         } else if (child.type === 'link_close') {
           inLink = false
-        } else if (inLink && child.type === 'text') {
+        } else if (inLink && child.type === 'text' && child.content) {
           const content = child.content.trim()
           const hasPeriod = doesStringEndWithPeriod(content)
           const hasQuotes = isStringQuoted(content)
 
           if (hasPeriod || hasQuotes) {
-            const range = getRange(line, content)
+            const range = line ? getRange(line, content) : []
             addError(
               onError,
-              child.lineNumber,
+              child.lineNumber || 1,
               'Remove quotes and/or period punctuation from the link title.',
               child.content,
               range,
diff --git a/src/content-render/liquid/data.ts b/src/content-render/liquid/data.ts
@@ -7,10 +7,13 @@ import { getDataByLanguage } from '@/data-directory/lib/get-data'
 const Syntax = /([a-z0-9/\\_.\-[\]]+)/i
 const SyntaxHelp = "Syntax Error in 'data' - Valid syntax: data [path]"
 
-// Using any for scope because it has custom environments property not in Liquid's Scope type
+// Using unknown for scope because it has custom environments property not in Liquid's Scope type
 interface CustomScope {
-  environments: any
-  [key: string]: any
+  environments: {
+    currentLanguage?: string
+    [key: string]: unknown
+  }
+  [key: string]: unknown
 }
 
 interface DataTag {
@@ -32,7 +35,7 @@ export default {
   },
 
   async render(scope: CustomScope) {
-    let text = getDataByLanguage(this.path, scope.environments.currentLanguage)
+    let text = getDataByLanguage(this.path, scope.environments.currentLanguage || '')
     if (text === undefined) {
       if (scope.environments.currentLanguage === 'en') {
         const message = `Can't find the key 'data ${this.path}' in the scope.`
diff --git a/src/fixtures/tests/internal-links.ts b/src/fixtures/tests/internal-links.ts
@@ -9,7 +9,7 @@ describe('autotitle', () => {
   test('internal links with AUTOTITLE resolves', async () => {
     const $: cheerio.Root = await getDOM('/get-started/foo/autotitling')
     const links = $('#article-contents a[href]')
-    links.each((i: number, element: any) => {
+    links.each((i: number, element: cheerio.Element) => {
       if ($(element).attr('href')?.includes('/get-started/start-your-journey/hello-world')) {
         expect($(element).text()).toBe('Hello World')
       }
@@ -49,13 +49,14 @@ describe('cross-version-links', () => {
 
       // Tests that the hardcoded prefix is always removed
       const firstLink = links.filter(
-        (i: number, element: any) => $(element).text() === 'Hello world always in free-pro-team',
+        (i: number, element: cheerio.Element) =>
+          $(element).text() === 'Hello world always in free-pro-team',
       )
       expect(firstLink.attr('href')).toBe('/en/get-started/start-your-journey/hello-world')
 
       // Tests that the second link always goes to enterprise-server@X.Y
       const secondLink = links.filter(
-        (i: number, element: any) =>
+        (i: number, element: cheerio.Element) =>
           $(element).text() === 'Autotitling page always in enterprise-server latest',
       )
       expect(secondLink.attr('href')).toBe(
@@ -72,29 +73,33 @@ describe('link-rewriting', () => {
 
     {
       const link = links.filter(
-        (i: number, element: any) => $(element).text() === 'Cross Version Linking',
+        (i: number, element: cheerio.Element) => $(element).text() === 'Cross Version Linking',
       )
       expect(link.attr('href')).toMatch('/en/get-started/')
     }
 
     // Some links are left untouched
 
     {
-      const link = links.filter((i: number, element: any) =>
+      const link = links.filter((i: number, element: cheerio.Element) =>
         $(element).text().includes('Enterprise 11.10'),
       )
       expect(link.attr('href')).toMatch('/en/enterprise/')
     }
     {
-      const link = links.filter((i: number, element: any) => $(element).text().includes('peterbe'))
+      const link = links.filter((i: number, element: cheerio.Element) =>
+        $(element).text().includes('peterbe'),
+      )
       expect(link.attr('href')).toMatch(/^https:/)
     }
     {
-      const link = links.filter((i: number, element: any) => $(element).text().includes('Picture'))
+      const link = links.filter((i: number, element: cheerio.Element) =>
+        $(element).text().includes('Picture'),
+      )
       expect(link.attr('href')).toMatch(/^\/assets\//)
     }
     {
-      const link = links.filter((i: number, element: any) =>
+      const link = links.filter((i: number, element: cheerio.Element) =>
         $(element).text().includes('GraphQL Schema'),
       )
       expect(link.attr('href')).toMatch(/^\/public\//)
@@ -108,7 +113,7 @@ describe('link-rewriting', () => {
     const links = $('#article-contents a[href]')
 
     const link = links.filter(
-      (i: number, element: any) => $(element).text() === 'Cross Version Linking',
+      (i: number, element: cheerio.Element) => $(element).text() === 'Cross Version Linking',
     )
     expect(link.attr('href')).toMatch('/en/enterprise-cloud@latest/get-started/')
   })
@@ -121,7 +126,7 @@ describe('link-rewriting', () => {
     const links = $('#article-contents a[href]')
 
     const link = links.filter(
-      (i: number, element: any) => $(element).text() === 'Cross Version Linking',
+      (i: number, element: cheerio.Element) => $(element).text() === 'Cross Version Linking',
     )
     expect(link.attr('href')).toMatch(
       `/en/enterprise-server@${enterpriseServerReleases.latestStable}/get-started/`,
@@ -133,14 +138,14 @@ describe('subcategory links', () => {
   test('no free-pro-team prefix', async () => {
     const $: cheerio.Root = await getDOM('/rest/actions')
     const links = $('[data-testid="table-of-contents"] a[href]')
-    links.each((i: number, element: any) => {
+    links.each((i: number, element: cheerio.Element) => {
       expect($(element).attr('href')).not.toContain('/free-pro-team@latest')
     })
   })
   test('enterprise-server prefix', async () => {
     const $: cheerio.Root = await getDOM('/enterprise-server@latest/rest/actions')
     const links = $('[data-testid="table-of-contents"] a[href]')
-    links.each((i: number, element: any) => {
+    links.each((i: number, element: cheerio.Element) => {
       expect($(element).attr('href')).toMatch(/\/enterprise-server@\d/)
     })
   })
diff --git a/src/graphql/tests/build-changelog.ts b/src/graphql/tests/build-changelog.ts
@@ -19,8 +19,8 @@ interface Preview {
   title: string
   description: string
   toggled_by: string
-  announcement: any
-  updates: any
+  announcement: unknown
+  updates: unknown
   toggled_on: string[]
   owning_teams: string[]
 }
@@ -33,7 +33,7 @@ interface UpcomingChange {
 
 interface IgnoredChange {
   type: string
-  [key: string]: any
+  [key: string]: unknown
 }
 
 interface IgnoredChangesSummary {
@@ -285,7 +285,7 @@ describe('ignored changes tracking', () => {
     // This should generate a TypeDescriptionAdded change type that gets ignored
     await createChangelogEntry(oldSchemaString, newSchemaString, [], [], [])
 
-    const ignoredChanges: IgnoredChange[] = getLastIgnoredChanges()
+    const ignoredChanges: IgnoredChange[] = getLastIgnoredChanges() as unknown as IgnoredChange[]
     expect(ignoredChanges.length).toBe(1)
     expect(ignoredChanges[0].type).toBe('TYPE_DESCRIPTION_ADDED')
   })
diff --git a/src/landings/components/ProductGuidesContext.tsx b/src/landings/components/ProductGuidesContext.tsx
@@ -1,5 +1,6 @@
 import { createContext, useContext } from 'react'
 import pick from 'lodash/pick'
+import type { ExtendedRequest } from '@/types'
 
 export type LearningTrack = {
   trackName: string
@@ -38,24 +39,45 @@ export const useProductGuidesContext = (): ProductGuidesContextT => {
   return context
 }
 
-export const getProductGuidesContextFromRequest = (req: any): ProductGuidesContextT => {
-  const page = req.context.page
+export const getProductGuidesContextFromRequest = (req: ExtendedRequest): ProductGuidesContextT => {
+  if (!req.context || !req.context.page) {
+    throw new Error('Request context or page is missing')
+  }
+
+  const page = req.context.page as typeof req.context.page & {
+    learningTracks?: Array<Record<string, unknown>>
+    includeGuides?: Array<Record<string, unknown>>
+  }
 
-  const learningTracks: LearningTrack[] = (page.learningTracks || []).map((track: any) => ({
-    ...pick(track, ['title', 'description', 'trackName', 'trackProduct']),
-    guides: (track.guides || []).map((guide: any) => {
-      return pick(guide, ['title', 'intro', 'href', 'page.type'])
+  const learningTracks: LearningTrack[] = (page.learningTracks || []).map(
+    (track: Record<string, unknown>) => ({
+      title: (track.title as string) || '',
+      description: (track.description as string) || '',
+      trackName: (track.trackName as string) || '',
+      trackProduct: (track.trackProduct as string) || '',
+      guides: ((track.guides as Array<Record<string, unknown>>) || []).map(
+        (guide: Record<string, unknown>) => ({
+          title: (guide.title as string) || '',
+          intro: (guide.intro as string) || '',
+          href: (guide.href as string) || '',
+          page: guide.page as { type: string } | undefined,
+        }),
+      ),
     }),
-  }))
+  )
 
   return {
     ...pick(page, ['title', 'intro']),
+    title: page.title || '',
+    intro: page.intro || '',
     learningTracks,
-    includeGuides: (page.includeGuides || []).map((guide: any) => {
+    includeGuides: (page.includeGuides || []).map((guide: Record<string, unknown>) => {
       return {
-        ...pick(guide, ['href', 'title', 'intro']),
-        type: guide.type || '',
-        topics: guide.topics || [],
+        href: (guide.href as string) || '',
+        title: (guide.title as string) || '',
+        intro: (guide.intro as string) || '',
+        type: (guide.type as string) || '',
+        topics: (guide.topics as Array<string>) || [],
       }
     }),
   }
diff --git a/src/languages/scripts/count-translation-corruptions.ts b/src/languages/scripts/count-translation-corruptions.ts
@@ -77,10 +77,10 @@ function run(languageCode: string, site: Site, englishReusables: Reusables) {
   const illegalTags = new Map<string, number>()
 
   function countError(error: TokenizationError, where: string) {
-    const originalError = (error as any).originalError
+    const originalError = (error as { originalError?: Error }).originalError
     const errorString = originalError ? originalError.message : error.message
     if (errorString.includes('illegal tag syntax')) {
-      const illegalTag = (error as any).token.content
+      const illegalTag = (error as unknown as { token: { content: string } }).token.content
       illegalTags.set(illegalTag, (illegalTags.get(illegalTag) || 0) + 1)
     }
     errors.set(errorString, (errors.get(errorString) || 0) + 1)
diff --git a/src/learning-track/lib/types.ts b/src/learning-track/lib/types.ts
@@ -2,18 +2,10 @@
  * Common types used across learning track components
  */
 
-/**
- * Basic context interface for rendering operations
- */
-export interface Context {
-  currentProduct?: string
-  currentLanguage?: string
-  currentVersion?: string
-  pages?: any
-  redirects?: any
-  // Additional properties that may be needed for rendering
-  [key: string]: any
-}
+import type { Context, Page as MainPage } from '@/types'
+
+// Re-export Context from main types to avoid duplicate definitions
+export type { Context }
 
 /**
  * Options for retrieving link data
@@ -49,11 +41,9 @@ export interface PageFeaturedLinks {
 
 /**
  * Page interface for basic page properties
+ * Using the main Page type from @/types
  */
-export interface Page {
-  renderTitle: (context: Context, opts: any) => Promise<string>
-  renderProp: (prop: string, context: Context, opts: any) => Promise<string>
-}
+export type Page = MainPage
 
 /**
  * Guide in a learning track
@@ -83,7 +73,7 @@ export interface LearningTrackMetadata {
   title: string
   description: string
   guides: string[]
-  versions?: any
+  versions?: unknown
 }
 
 /**
diff --git a/src/observability/tests/failbot.ts b/src/observability/tests/failbot.ts
@@ -4,7 +4,7 @@ import nock from 'nock'
 import FailBot from '../lib/failbot'
 
 describe('FailBot', () => {
-  const requestBodiesSent: any[] = []
+  const requestBodiesSent: unknown[] = []
 
   beforeEach(() => {
     delete process.env.HAYSTACK_URL
diff --git a/src/rest/api/anchor-redirect.ts b/src/rest/api/anchor-redirect.ts
@@ -1,4 +1,4 @@
-import express from 'express'
+import express, { RequestHandler } from 'express'
 import path from 'path'
 
 import { readCompressedJsonFileFallbackLazily } from '@/frame/lib/read-json-file'
@@ -12,20 +12,22 @@ const clientSideRestAPIRedirects = readCompressedJsonFileFallbackLazily(
 const router = express.Router()
 
 // Returns a client side redirect if one exists for the given path.
-// Note: Using 'any' for req/res because Express types are complex and the
-// function signature is constrained by the router.get() overloads
-router.get('/', function redirects(req: any, res: any) {
+const redirects: RequestHandler = (req, res) => {
   if (!req.query.path) {
-    return res.status(400).send("Missing 'path' query string")
+    res.status(400).send("Missing 'path' query string")
+    return
   }
   if (!req.query.hash) {
-    return res.status(400).send("Missing 'hash' query string")
+    res.status(400).send("Missing 'hash' query string")
+    return
   }
 
   defaultCacheControl(res)
 
   const redirectFrom: string = `${req.query.path}#${req.query.hash}`
   res.status(200).send({ to: clientSideRestAPIRedirects()[redirectFrom] })
-})
+}
+
+router.get('/', redirects)
 
 export default router
diff --git a/src/rest/scripts/openapi-check.ts b/src/rest/scripts/openapi-check.ts
diff --git a/src/rest/scripts/utils/get-body-params.ts b/src/rest/scripts/utils/get-body-params.ts
diff --git a/src/rest/scripts/utils/get-operations.ts b/src/rest/scripts/utils/get-operations.ts
diff --git a/src/webhooks/tests/oneof-handling.ts b/src/webhooks/tests/oneof-handling.ts
diff --git a/src/workflows/ready-for-docs-review.ts b/src/workflows/ready-for-docs-review.ts

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ describe('autotitle', () => {`
`9`	`9`	`test('internal links with AUTOTITLE resolves', async () => {`
`10`	`10`	`const $: cheerio.Root = await getDOM('/get-started/foo/autotitling')`
`11`	`11`	`const links = $('#article-contents a[href]')`
`12`		`- links.each((i: number, element: any) => {`
	`12`	`+ links.each((i: number, element: cheerio.Element) => {`
`13`	`13`	`if ($(element).attr('href')?.includes('/get-started/start-your-journey/hello-world')) {`
`14`	`14`	`expect($(element).text()).toBe('Hello World')`
`15`	`15`	`}`
`@@ -49,13 +49,14 @@ describe('cross-version-links', () => {`
`49`	`49`
`50`	`50`	`// Tests that the hardcoded prefix is always removed`
`51`	`51`	`const firstLink = links.filter(`
`52`		`- (i: number, element: any) => $(element).text() === 'Hello world always in free-pro-team',`
	`52`	`+ (i: number, element: cheerio.Element) =>`
	`53`	`+ $(element).text() === 'Hello world always in free-pro-team',`
`53`	`54`	`)`
`54`	`55`	`expect(firstLink.attr('href')).toBe('/en/get-started/start-your-journey/hello-world')`
`55`	`56`
`56`	`57`	`// Tests that the second link always goes to enterprise-server@X.Y`
`57`	`58`	`const secondLink = links.filter(`
`58`		`- (i: number, element: any) =>`
	`59`	`+ (i: number, element: cheerio.Element) =>`
`59`	`60`	`$(element).text() === 'Autotitling page always in enterprise-server latest',`
`60`	`61`	`)`
`61`	`62`	`expect(secondLink.attr('href')).toBe(`
`@@ -72,29 +73,33 @@ describe('link-rewriting', () => {`
`72`	`73`
`73`	`74`	`{`
`74`	`75`	`const link = links.filter(`
`75`		`- (i: number, element: any) => $(element).text() === 'Cross Version Linking',`
	`76`	`+ (i: number, element: cheerio.Element) => $(element).text() === 'Cross Version Linking',`
`76`	`77`	`)`
`77`	`78`	`expect(link.attr('href')).toMatch('/en/get-started/')`
`78`	`79`	`}`
`79`	`80`
`80`	`81`	`// Some links are left untouched`
`81`	`82`
`82`	`83`	`{`
`83`		`- const link = links.filter((i: number, element: any) =>`
	`84`	`+ const link = links.filter((i: number, element: cheerio.Element) =>`
`84`	`85`	`$(element).text().includes('Enterprise 11.10'),`
`85`	`86`	`)`
`86`	`87`	`expect(link.attr('href')).toMatch('/en/enterprise/')`
`87`	`88`	`}`
`88`	`89`	`{`
`89`		`- const link = links.filter((i: number, element: any) => $(element).text().includes('peterbe'))`
	`90`	`+ const link = links.filter((i: number, element: cheerio.Element) =>`
	`91`	`+ $(element).text().includes('peterbe'),`
	`92`	`+ )`
`90`	`93`	`expect(link.attr('href')).toMatch(/^https:/)`
`91`	`94`	`}`
`92`	`95`	`{`
`93`		`- const link = links.filter((i: number, element: any) => $(element).text().includes('Picture'))`
	`96`	`+ const link = links.filter((i: number, element: cheerio.Element) =>`
	`97`	`+ $(element).text().includes('Picture'),`
	`98`	`+ )`
`94`	`99`	`expect(link.attr('href')).toMatch(/^\/assets\//)`
`95`	`100`	`}`
`96`	`101`	`{`
`97`		`- const link = links.filter((i: number, element: any) =>`
	`102`	`+ const link = links.filter((i: number, element: cheerio.Element) =>`
`98`	`103`	`$(element).text().includes('GraphQL Schema'),`
`99`	`104`	`)`
`100`	`105`	`expect(link.attr('href')).toMatch(/^\/public\//)`
`@@ -108,7 +113,7 @@ describe('link-rewriting', () => {`
`108`	`113`	`const links = $('#article-contents a[href]')`
`109`	`114`
`110`	`115`	`const link = links.filter(`
`111`		`- (i: number, element: any) => $(element).text() === 'Cross Version Linking',`
	`116`	`+ (i: number, element: cheerio.Element) => $(element).text() === 'Cross Version Linking',`
`112`	`117`	`)`
`113`	`118`	`expect(link.attr('href')).toMatch('/en/enterprise-cloud@latest/get-started/')`
`114`	`119`	`})`
`@@ -121,7 +126,7 @@ describe('link-rewriting', () => {`
`121`	`126`	`const links = $('#article-contents a[href]')`
`122`	`127`
`123`	`128`	`const link = links.filter(`
`124`		`- (i: number, element: any) => $(element).text() === 'Cross Version Linking',`
	`129`	`+ (i: number, element: cheerio.Element) => $(element).text() === 'Cross Version Linking',`
`125`	`130`	`)`
`126`	`131`	`expect(link.attr('href')).toMatch(`
`127`	`132`	`/en/enterprise-server@${enterpriseServerReleases.latestStable}/get-started/`,
`@@ -133,14 +138,14 @@ describe('subcategory links', () => {`
`133`	`138`	`test('no free-pro-team prefix', async () => {`
`134`	`139`	`const $: cheerio.Root = await getDOM('/rest/actions')`
`135`	`140`	`const links = $('[data-testid="table-of-contents"] a[href]')`
`136`		`- links.each((i: number, element: any) => {`
	`141`	`+ links.each((i: number, element: cheerio.Element) => {`
`137`	`142`	`expect($(element).attr('href')).not.toContain('/free-pro-team@latest')`
`138`	`143`	`})`
`139`	`144`	`})`
`140`	`145`	`test('enterprise-server prefix', async () => {`
`141`	`146`	`const $: cheerio.Root = await getDOM('/enterprise-server@latest/rest/actions')`
`142`	`147`	`const links = $('[data-testid="table-of-contents"] a[href]')`
`143`		`- links.each((i: number, element: any) => {`
	`148`	`+ links.each((i: number, element: cheerio.Element) => {`
`144`	`149`	`expect($(element).attr('href')).toMatch(/\/enterprise-server@\d/)`
`145`	`150`	`})`
`146`	`151`	`})`