Skip to content

Commit dd2164e

Browse files
committed
Add distro codename into RELEASE_DIR path for linux
The RELEASE_DIR path currently determines the S3 object key (perhaps a bit obtuse?), so it must be different for Ubuntu 22.04 and Ubuntu 24.04. Using their codenames (i.e. "jammy" and "noble") seems like a good choice.
1 parent 2df80e9 commit dd2164e

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

scripts/release.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,15 @@ else
219219
BUNDLE_DIR=$(readlink -f "$PWD/../target/release/bundle")
220220
fi
221221

222+
# The release dir determines a (significant portion of) the final S3 object key.
222223
RELEASE_DIR="$DIST/$OS/$ARCH"
224+
if [ "$OS" = "linux" ]; then
225+
# We build for multiple linux distros and need distinct keys for them.
226+
RELEASE_DIR="$DIST/$OS/$(lsb_release -cs)/$ARCH"
227+
fi
228+
229+
echo "Resolved RELEASE_DIR=$RELEASE_DIR"
230+
223231
mkdir -p "$RELEASE_DIR"
224232

225233
if [ "$OS" = "macos" ]; then

0 commit comments

Comments
 (0)