refactor: avoid borrowed git2::Oid as it's a copy type.

Usually this makes the affected code simpler.

Author: Byron

crates/gitbutler-branch-actions/src/branch_manager/branch_removal.rs

@@ -102,7 +102,7 @@ impl BranchManager<'_> {
                         .map(|file| (file.path, file.hunks))
                         .collect::<Vec<(PathBuf, Vec<VirtualBranchHunk>)>>();
                     let tree_oid =
-                        gitbutler_diff::write::hunks_onto_oid(self.ctx, &branch.head, files)?;
+                        gitbutler_diff::write::hunks_onto_oid(self.ctx, branch.head, files)?;
                     let branch_tree = repo.find_tree(tree_oid)?;
                     let mut result =
                         repo.merge_trees(&base_tree, &final_tree, &branch_tree, None)?;

crates/gitbutler-branch-actions/src/status.rs

@@ -213,7 +213,7 @@ pub fn get_applied_status_cached(
     // write updated state if not resolving
     if !ctx.is_resolving() {
         for (vbranch, files) in &mut hunks_by_branch {
-            vbranch.tree = gitbutler_diff::write::hunks_onto_oid(ctx, &vbranch.head, files)?;
+            vbranch.tree = gitbutler_diff::write::hunks_onto_oid(ctx, vbranch.head, files)?;
             vb_state
                 .set_branch(vbranch.clone())
                 .context(format!("failed to write virtual branch {}", vbranch.name))?;

crates/gitbutler-branch-actions/src/virtual.rs

@@ -158,7 +158,7 @@ pub fn unapply_ownership(
                 .map(|file| (file.path, file.hunks))
                 .collect::<Vec<(PathBuf, Vec<VirtualBranchHunk>)>>();
             let tree_oid =
-                gitbutler_diff::write::hunks_onto_oid(ctx, &integration_commit_id, files)?;
+                gitbutler_diff::write::hunks_onto_oid(ctx, integration_commit_id, files)?;
             let branch_tree = repo.find_tree(tree_oid)?;
             let mut result = repo.merge_trees(&base_tree, &final_tree, &branch_tree, None)?;
             let final_tree_oid = result.write_tree_to(ctx.repository())?;
@@ -1043,7 +1043,7 @@ pub(crate) fn push(
     };
 
     ctx.push(
-        &vbranch.head,
+        vbranch.head,
         &remote_branch,
         with_force,
         credentials,

crates/gitbutler-diff/src/write.rs

@@ -15,13 +15,13 @@ use crate::GitHunk;
 // and writes it as a new tree for storage
 pub fn hunks_onto_oid<T>(
     ctx: &CommandContext,
-    target: &git2::Oid,
+    target: git2::Oid,
     files: impl IntoIterator<Item = (impl Borrow<PathBuf>, impl Borrow<Vec<T>>)>,
 ) -> Result<git2::Oid>
 where
     T: Into<GitHunk> + Clone,
 {
-    hunks_onto_commit(ctx, *target, files)
+    hunks_onto_commit(ctx, target, files)
 }
 
 pub fn hunks_onto_commit<T>(

crates/gitbutler-repo/src/change_reference.rs

@@ -146,7 +146,7 @@ pub fn push_change_reference(
     let commit =
         commit_by_branch_id_and_change_id(ctx, &vbranch, &handle, reference.change_id.clone())?;
     ctx.push(
-        &commit.id(),
+        commit.id(),
         &upstream_refname,
         with_force,
         credentials,

crates/gitbutler-repo/src/repository.rs

@@ -14,7 +14,7 @@ pub trait RepoActionsExt {
         -> Result<()>;
     fn push(
         &self,
-        head: &git2::Oid,
+        head: git2::Oid,
         branch: &RemoteRefname,
         with_force: bool,
         credentials: &Helper,
@@ -67,14 +67,14 @@ impl RepoActionsExt for CommandContext {
         let refname =
             RemoteRefname::from_str(&format!("refs/remotes/{remote_name}/{branch_name}",))?;
 
-        match self.push(&commit_id, &refname, false, credentials, None, askpass) {
+        match self.push(commit_id, &refname, false, credentials, None, askpass) {
             Ok(()) => Ok(()),
             Err(e) => Err(anyhow::anyhow!(e.to_string())),
         }?;
 
         let empty_refspec = Some(format!(":refs/heads/{}", branch_name));
         match self.push(
-            &commit_id,
+            commit_id,
             &refname,
             false,
             credentials,
@@ -254,7 +254,7 @@ impl RepoActionsExt for CommandContext {
 
     fn push(
         &self,
-        head: &git2::Oid,
+        head: git2::Oid,
         branch: &RemoteRefname,
         with_force: bool,
         credentials: &Helper,