Commit f6b0259
authored
Use 127.0.0.1 redirect over localhost for GitHub (#1286)
Use an IPv4 loopback redirect URL instead of the `localhost` name. This
is in accordance with the recommendation in the OAuth spec[^1][^2] and
also GitHub's documentation[^3].
Note that this change depends on an update to the Git Credential Manager
OAuth application on GitHub to add the "http://127.0.0.1/" redirect
(with a trailing slash!). We will be strictly adding the new URL, and
keep the older localhost-based redirect URL untouched for older clients.
The change to the OAuth app registration can occur before this is
merged.
Fixes #594
[^1]: https://datatracker.ietf.org/doc/html/rfc8252#section-7.3
[^2]: https://datatracker.ietf.org/doc/html/rfc8252#section-8.3
[^3]:
https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/authorizing-oauth-apps#loopback-redirect-urlsFile tree
1 file changed
+1
-1
lines changed1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
0 commit comments