Merge pull request #15 from ginkelsoft-development/fix/elasticsearch-delete-implementation

fix: implement actual document deletion in Elasticsearch

Author: ginkelsoft-development

src/Services/ElasticsearchService.php

@@ -88,4 +88,19 @@ public function search(string $index, array $query): array
 
         return $response->json('hits.hits', []);
     }
+
+    /**
+     * Delete documents matching a query from an Elasticsearch index.
+     *
+     * @param  string  $index  The Elasticsearch index name.
+     * @param  array<string, mixed>  $query  The Elasticsearch query body.
+     * @return bool  True if successful, false otherwise.
+     */
+    public function deleteByQuery(string $index, array $query): bool
+    {
+        $url = "{$this->host}/{$index}/_delete_by_query";
+        $response = Http::post($url, $query);
+
+        return $response->successful();
+    }
 }

src/Traits/HasEncryptedSearchIndex.php

@@ -177,9 +177,10 @@ protected function syncToElasticsearch(array $rows): void
     }
 
     /**
-     * Remove this model’s tokens from the configured Elasticsearch index.
+     * Remove this model's tokens from the configured Elasticsearch index.
      *
-     * Uses a boolean query to match documents by model_type and model_id.
+     * Uses delete-by-query to efficiently remove all documents matching
+     * the model_type and model_id.
      *
      * @return void
      */
@@ -200,8 +201,7 @@ protected function removeFromElasticsearch(): void
         ];
 
         try {
-            $service->search($index, $query);
-            // Optional: replace with Elasticsearch delete-by-query API for optimization
+            $service->deleteByQuery($index, $query);
         } catch (\Throwable $e) {
             logger()->warning("Failed to remove Elasticsearch docs for model {$this->getKey()}: {$e->getMessage()}");
         }