Merge pull request #18 from ginkelsoft-development/fix/optimize-database-index-upsert

ginkelsoft-development · web-flow · commit 5979e43803e5 · 2025-10-13T11:31:16.000+02:00
improve: add clarifying comments to database index update process
diff --git a/src/Traits/HasEncryptedSearchIndex.php b/src/Traits/HasEncryptedSearchIndex.php
@@ -130,10 +130,12 @@ public function updateSearchIndex(): void
         if ($useElastic) {
             $this->syncToElasticsearch($rows);
         } else {
+            // Remove existing tokens for this model before inserting new ones
             SearchIndex::where('model_type', static::class)
                 ->where('model_id', $this->getKey())
                 ->delete();
 
+            // Bulk insert all new tokens in a single query
             SearchIndex::insert($rows);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -130,10 +130,12 @@ public function updateSearchIndex(): void`
`130`	`130`	`if ($useElastic) {`
`131`	`131`	`$this->syncToElasticsearch($rows);`
`132`	`132`	`} else {`
	`133`	`+ // Remove existing tokens for this model before inserting new ones`
`133`	`134`	`SearchIndex::where('model_type', static::class)`
`134`	`135`	`->where('model_id', $this->getKey())`
`135`	`136`	`->delete();`
`136`	`137`
	`138`	`+ // Bulk insert all new tokens in a single query`
`137`	`139`	`SearchIndex::insert($rows);`
`138`	`140`	`}`
`139`	`141`	`}`