SDK-818: Add coverage for empty Remember Me ID on receipt

Author: davidgrayston

tests/ActivityDetailsTest.php

@@ -29,34 +29,26 @@ class ActivityDetailsTest extends TestCase
      */
     public $applicationProfile;
 
-    public function setUp()
-    {
-        $this->activityDetails = new ActivityDetails(
-            new Receipt($this->getReceiptArray()),
-            $this->getPem()
-        );
-        $this->profile = $this->activityDetails->getProfile();
-        $this->applicationProfile = $this->activityDetails->getApplicationProfile();
-    }
-
     /**
-     * Get pem file contents.
-     *
-     * @return string
+     * @var string Pem file contents.
      */
-    private function getPem()
-    {
-        return file_get_contents(PEM_FILE);
-    }
+    private $pem;
 
     /**
-     * Get test receipt.
-     *
-     * @return array
+     * @var array Receipt array.
      */
-    private function getReceiptArray()
+    private $receiptArr;
+
+    public function setUp()
     {
-        return json_decode(file_get_contents(RECEIPT_JSON), true)['receipt'];
+        $this->pem = file_get_contents(PEM_FILE);
+        $this->receiptArr = json_decode(file_get_contents(RECEIPT_JSON), true)['receipt'];
+        $this->activityDetails = new ActivityDetails(
+            new Receipt($this->receiptArr),
+            $this->pem
+        );
+        $this->profile = $this->activityDetails->getProfile();
+        $this->applicationProfile = $this->activityDetails->getApplicationProfile();
     }
 
     /**
@@ -82,11 +74,10 @@ public function testGetRememberMeId()
     public function testGetRememberMeIdNotPresent()
     {
         // Remove Remember Me ID from test receipt.
-        $receiptArr = $this->getReceiptArray();
-        unset($receiptArr['remember_me_id']);
-        $receipt = new Receipt($receiptArr);
+        unset($this->receiptArr['remember_me_id']);
+        $receipt = new Receipt($this->receiptArr);
 
-        $activityDetails = new ActivityDetails($receipt, $this->getPem());
+        $activityDetails = new ActivityDetails($receipt, $this->pem);
         $this->assertNull($activityDetails->getRememberMeId());
     }
 
@@ -96,11 +87,10 @@ public function testGetRememberMeIdNotPresent()
     public function testGetRememberMeIdEmpty()
     {
         // Set Remember Me ID to empty string.
-        $receiptArr = $this->getReceiptArray();
-        $receiptArr['remember_me_id'] = '';
-        $receipt = new Receipt($receiptArr);
+        $this->receiptArr['remember_me_id'] = '';
+        $receipt = new Receipt($this->receiptArr);
 
-        $activityDetails = new ActivityDetails($receipt, $this->getPem());
+        $activityDetails = new ActivityDetails($receipt, $this->pem);
         $this->assertEquals('', $activityDetails->getRememberMeId());
     }
 

tests/Entity/ReceiptTest.php

@@ -17,6 +17,11 @@ class ReceiptTest extends TestCase
      */
     public $pem;
 
+    /**
+     * @var array Receipt array.
+     */
+    private $receiptArr;
+
     /**
      * @var Receipt
      */
@@ -25,8 +30,8 @@ class ReceiptTest extends TestCase
     public function setup()
     {
         $this->pem = file_get_contents(PEM_FILE);
-        $receiptArr = json_decode(file_get_contents(RECEIPT_JSON), true);
-        $this->receipt = new Receipt($receiptArr['receipt']);
+        $this->receiptArr = json_decode(file_get_contents(RECEIPT_JSON), true)['receipt'];
+        $this->receipt = new Receipt($this->receiptArr);
     }
 
     /**
@@ -60,12 +65,21 @@ public function testGetRememberMeId()
      */
     public function testGetRememberMeIdNotPresent()
     {
-        $receiptArr = json_decode(file_get_contents(RECEIPT_JSON), true);
-        unset($receiptArr['receipt']['remember_me_id']);
-        $receipt = new Receipt($receiptArr['receipt']);
+        unset($this->receiptArr['remember_me_id']);
+        $receipt = new Receipt($this->receiptArr);
         $this->assertNull($receipt->getRememberMeId());
     }
 
+    /**
+     * @covers ::getRememberMeId
+     */
+    public function testGetRememberMeIdEmpty()
+    {
+        $this->receiptArr['remember_me_id'] = '';
+        $receipt = new Receipt($this->receiptArr);
+        $this->assertEquals('', $receipt->getRememberMeId());
+    }
+
     /**
      * @covers ::getSharingOutcome
      */