Skip to content

Commit f3f2e82

Browse files
committed
feat(sourcemaps): Remove use-artifact-bundle flag
Remove the no-op --use-artifact-bundle CLI flag, drop the JS option, and document the breaking change. Closes #2352 Closes [CLI-20](https://linear.app/getsentry/issue/CLI-20/remove-use-artifact-bundle-option)
1 parent c66e7c3 commit f3f2e82

File tree

4 files changed

+1
-31
lines changed

4 files changed

+1
-31
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ we should rename this section to "Unreleased" -->
2323
- Removed the `--started` argument from the `sentry-cli releases finalize` command ([#XXXX](TODO)). This argument is a no-op, so any users using it should simply stop using it.
2424
- In the JS API, the `SentryCli.execute` method's `live` parameter now only takes boolean values ([#2971](https://github.com/getsentry/sentry-cli/pull/2971)). Setting `live` to `true` now behaves like `'rejectOnError'` did previously, with a zero exit status resolving the returned promise with `"success (live mode)"` and a non-zero status rejecting the promise with an error message.
2525
- In the JS API, the `option` parameter to `Releases.uploadSourceMaps` no longer takes a `live` property ([#2971](https://github.com/getsentry/sentry-cli/pull/2971)). We now always execute the command with `live` set to `true`.
26+
- Removed the `--use-artifact-bundle` flag from `sentry-cli sourcemaps upload`, along with the corresponding `useArtifactBundle` JavaScript option ([#XXXX](TODO)). The flag was a no-op that only emitted a deprecation warning.
2627

2728
#### Node.js Wrapper Breakages
2829

lib/releases/options/uploadSourcemaps.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,4 @@ module.exports = {
5555
param: '--ext',
5656
type: 'array',
5757
},
58-
useArtifactBundle: {
59-
param: '--use-artifact-bundle',
60-
type: 'boolean',
61-
},
6258
};

lib/types.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -137,14 +137,6 @@ export interface SentryCliUploadSourceMapsOptions {
137137
* Usually your build number.
138138
*/
139139
dist?: string;
140-
/**
141-
* Force use of new Artifact Bundles upload, that enables use of Debug ID for Source Maps discovery,
142-
* even when the Sentry server does not declare support for it.
143-
*
144-
* @deprecated This option is deprecated and will be removed in the next major version. Sentry CLI
145-
* should always respect what the server says it supports.
146-
*/
147-
useArtifactBundle?: boolean;
148140
}
149141

150142
/**

src/commands/sourcemaps/upload.rs

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#![expect(clippy::unwrap_used, reason = "contains legacy code which uses unwrap")]
22

3-
use std::env;
43
use std::path::PathBuf;
54
use std::time::Duration;
65

@@ -223,17 +222,6 @@ pub fn make_command(command: Command) -> Command {
223222
uploaded.",
224223
),
225224
)
226-
.arg(
227-
Arg::new("use_artifact_bundle")
228-
.long("use-artifact-bundle")
229-
.action(ArgAction::SetTrue)
230-
.help(
231-
"[DEPRECATED] Force artifact bundles to be used for upload, even when not \
232-
supported by the server. This option has always only been intended for \
233-
internal use, and it is now officially deprecated.",
234-
)
235-
.hide(true),
236-
)
237225
// Legacy flag that has no effect, left hidden for backward compatibility
238226
.arg(
239227
Arg::new("rewrite")
@@ -431,13 +419,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
431419
let mut processor = SourceMapProcessor::new();
432420
let chunk_upload_options = api.authenticated()?.get_chunk_upload_options(&org)?;
433421

434-
if matches.get_flag("use_artifact_bundle")
435-
|| env::var("SENTRY_FORCE_ARTIFACT_BUNDLES").ok().as_deref() == Some("1")
436-
{
437-
log::warn!("The --use-artifact-bundle option and the SENTRY_FORCE_ARTIFACT_BUNDLES environment variable \
438-
are both deprecated, and both will be removed in the next major version.");
439-
}
440-
441422
if matches.contains_id("bundle") && matches.contains_id("bundle_sourcemap") {
442423
process_sources_from_bundle(matches, &mut processor)?;
443424
} else {

0 commit comments

Comments
 (0)