perf(sourcemaps): Elminate unnecessary HTTP call (#2913)

### Description

In some cases, we were making an HTTP call to list release files to
determine whether certain sources were already uploaded. However, if the
sources are uploaded as artifact bundles (the default), they would not
get returned from this endpoint, so the HTTP call is unnecessary.
Removing the call should speed up the `sourcemaps upload` command
somewhat.

### Issues

- Resolves #2912
- Resolves CLI-213

Author: szokeasaurusrex

CHANGELOG.md

@@ -10,11 +10,16 @@
 
 - Deprecated the `upload-proguard` subcommand's `--platform` flag ([#2863](https://github.com/getsentry/sentry-cli/pull/2863)). This flag appears to have been a no-op for some time, so we will remove it in the next major.
 - Deprecated the `upload-proguard` subcommand's `--android-manifest` flag ([#2891](https://github.com/getsentry/sentry-cli/pull/2891)). This flag appears to have been a no-op for some time, so we will remove it in the next major.
+- Deprecated the `sentry-cli sourcemaps upload` command's `--no-dedupe` flag ([#2913](https://github.com/getsentry/sentry-cli/pull/2913)). The flag was no longer relevant for sourcemap uploads to modern Sentry servers; the flag is now a no-op.
 
 ### Fixes
 
 - Fix autofilled git base metadata (`--base-ref`, `--base-sha`) when using the `build upload` subcommand in git repos. Previously this worked only in the contexts of GitHub workflows ([#2897](https://github.com/getsentry/sentry-cli/pull/2897), [#2898](https://github.com/getsentry/sentry-cli/pull/2898)).
 
+### Performance
+
+- Slightly sped up the `sentry-cli sourcemaps upload` command by elminating an HTTP request to the Sentry server, which was not required in most cases ([#2913](https://github.com/getsentry/sentry-cli/pull/2913)).
+
 ## 2.57.0
 
 ### New Features

src/commands/debug_files/bundle_jvm.rs

@@ -65,7 +65,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
         note: None,
         wait: true,
         max_wait: DEFAULT_MAX_WAIT,
-        dedupe: false,
         chunk_upload_options: chunk_upload_options.as_ref(),
     };
     let path = matches.get_one::<PathBuf>("path").unwrap();

src/commands/files/upload.rs

@@ -159,7 +159,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
         note: None,
         wait,
         max_wait,
-        dedupe: false,
         chunk_upload_options: chunk_upload_options.as_ref(),
     };
 

src/commands/react_native/appcenter.rs

@@ -202,7 +202,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
                 note: None,
                 wait,
                 max_wait,
-                dedupe: false,
                 chunk_upload_options: chunk_upload_options.as_ref(),
             })?;
         }
@@ -221,7 +220,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
                     note: None,
                     wait,
                     max_wait,
-                    dedupe: false,
                     chunk_upload_options: chunk_upload_options.as_ref(),
                 })?;
             }

src/commands/react_native/gradle.rs

@@ -129,7 +129,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
                 note: None,
                 wait,
                 max_wait,
-                dedupe: false,
                 chunk_upload_options: chunk_upload_options.as_ref(),
             })?;
         }
@@ -143,7 +142,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
             note: None,
             wait,
             max_wait,
-            dedupe: false,
             chunk_upload_options: chunk_upload_options.as_ref(),
         })?;
     }

src/commands/react_native/xcode.rs

@@ -351,7 +351,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
             note: None,
             wait,
             max_wait,
-            dedupe: false,
             chunk_upload_options: chunk_upload_options.as_ref(),
         })?;
     } else {
@@ -387,7 +386,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
                     note: None,
                     wait,
                     max_wait,
-                    dedupe: false,
                     chunk_upload_options: chunk_upload_options.as_ref(),
                 })?;
             }
@@ -401,7 +399,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
                         note: None,
                         wait,
                         max_wait,
-                        dedupe: false,
                         chunk_upload_options: chunk_upload_options.as_ref(),
                     })?;
                 }

src/commands/sourcemaps/upload.rs

@@ -193,11 +193,8 @@ pub fn make_command(command: Command) -> Command {
             Arg::new("no_dedupe")
                 .long("no-dedupe")
                 .action(ArgAction::SetTrue)
-                .help(
-                    "Skip artifacts deduplication prior to uploading. \
-                    This will force all artifacts to be uploaded, \
-                    no matter whether they are already present on the server.",
-                ),
+                .hide(true)
+                .help("[DEPRECATED] This flag has no effect and is scheduled for removal."),
         )
         .arg(
             Arg::new("extensions")
@@ -419,6 +416,13 @@ fn process_sources_from_paths(
 }
 
 pub fn execute(matches: &ArgMatches) -> Result<()> {
+    if matches.get_flag("no_dedupe") {
+        log::warn!(
+            "[DEPRECATION NOTICE] The --no-dedupe flag is deprecated and has no \
+            effect. It will be removed in the next major version."
+        );
+    }
+
     let config = Config::current();
     let version = config.get_release_with_legacy_fallback(matches).ok();
     let org = config.get_org(matches)?;
@@ -457,7 +461,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
         note: matches.get_one::<String>("note").map(String::as_str),
         wait,
         max_wait,
-        dedupe: !matches.get_flag("no_dedupe"),
         chunk_upload_options: chunk_upload_options.as_ref(),
     };
 

src/utils/file_upload.rs

@@ -28,7 +28,7 @@ use crate::api::NewRelease;
 use crate::api::{Api, ChunkServerOptions, ChunkUploadCapability};
 use crate::constants::DEFAULT_MAX_WAIT;
 use crate::utils::chunks::{upload_chunks, Chunk, ASSEMBLE_POLL_INTERVAL};
-use crate::utils::fs::{get_sha1_checksum, get_sha1_checksums, TempFile};
+use crate::utils::fs::{get_sha1_checksums, TempFile};
 use crate::utils::non_empty::NonEmptySlice;
 use crate::utils::progress::{ProgressBar, ProgressBarMode, ProgressStyle};
 
@@ -95,7 +95,6 @@ pub struct UploadContext<'a> {
     pub note: Option<&'a str>,
     pub wait: bool,
     pub max_wait: Duration,
-    pub dedupe: bool,
     pub chunk_upload_options: Option<&'a ChunkServerOptions>,
 }
 
@@ -308,11 +307,6 @@ impl SourceFile {
         source_file
     }
 
-    /// Calculates and returns the SHA1 checksum of the file.
-    pub fn checksum(&self) -> Result<Digest> {
-        get_sha1_checksum(&**self.contents)
-    }
-
     /// Returns the value of the "debug-id" header.
     pub fn debug_id(&self) -> Option<&String> {
         self.headers.get("debug-id")
@@ -902,7 +896,6 @@ mod tests {
             note: None,
             wait: false,
             max_wait: DEFAULT_MAX_WAIT,
-            dedupe: true,
             chunk_upload_options: None,
         };
 

src/utils/sourcemaps.rs

@@ -6,21 +6,18 @@ use std::io::Write as _;
 use std::mem;
 use std::path::{Path, PathBuf};
 use std::str;
-use std::str::FromStr as _;
 use std::sync::Arc;
 
 use anyhow::{anyhow, bail, Context as _, Error, Result};
 use console::style;
 use indicatif::ProgressStyle;
 use log::{debug, info, warn};
 use sentry::types::DebugId;
-use sha1_smol::Digest;
 use sourcemap::{DecodedMap, SourceMap};
 use symbolic::debuginfo::js::discover_sourcemaps_location;
 use symbolic::debuginfo::sourcebundle::SourceFileType;
 use url::Url;
 
-use crate::api::Api;
 use crate::utils::file_search::ReleaseFileMatch;
 use crate::utils::file_upload::{
     initialize_legacy_release_upload, FileUpload, SourceFile, SourceFiles, UploadContext,
@@ -666,54 +663,6 @@ impl SourceMapProcessor {
         }
     }
 
-    /// Flags the collected sources whether they have already been uploaded before
-    /// (based on their checksum), and returns the number of files that *do* need an upload.
-    fn flag_uploaded_sources(&mut self, context: &UploadContext<'_>) -> usize {
-        let mut files_needing_upload = self.sources.len();
-
-        if !context.dedupe {
-            return files_needing_upload;
-        }
-
-        // This endpoint only supports at most one project, and a release is required.
-        // If the upload contains multiple projects or no release, we do not use deduplication.
-        let (project, release) = match (context.projects.as_deref(), context.release) {
-            (Some([project]), Some(release)) => (Some(project.as_str()), release),
-            (None, Some(release)) => (None, release),
-            _ => return files_needing_upload,
-        };
-
-        let mut sources_checksums: Vec<_> = self
-            .sources
-            .values()
-            .filter_map(|s| s.checksum().map(|c| c.to_string()).ok())
-            .collect();
-
-        // Checksums need to be sorted in order to satisfy integration tests constraints.
-        sources_checksums.sort();
-
-        let api = Api::current();
-
-        if let Ok(artifacts) = api.authenticated().and_then(|api| {
-            api.list_release_files_by_checksum(context.org, project, release, &sources_checksums)
-        }) {
-            let already_uploaded_checksums: HashSet<_> = artifacts
-                .into_iter()
-                .filter_map(|artifact| Digest::from_str(&artifact.sha1).ok())
-                .collect();
-
-            for source in self.sources.values_mut() {
-                if let Ok(checksum) = source.checksum() {
-                    if already_uploaded_checksums.contains(&checksum) {
-                        source.already_uploaded = true;
-                        files_needing_upload -= 1;
-                    }
-                }
-            }
-        }
-        files_needing_upload
-    }
-
     /// Uploads all files, and on success, returns the number of files that were
     /// uploaded, wrapped in Ok()
     pub fn upload(&mut self, context: &UploadContext<'_>) -> Result<usize> {
@@ -752,7 +701,7 @@ impl SourceMapProcessor {
                 }
             }
         }
-        let files_needing_upload = self.flag_uploaded_sources(context);
+        let files_needing_upload = self.sources.len();
         if files_needing_upload > 0 {
             let mut uploader = FileUpload::new(context);
             uploader.files(&self.sources);

tests/integration/_cases/sourcemaps/sourcemaps-upload-help.trycmd

@@ -74,9 +74,6 @@ Options:
           Path to the application bundle (indexed, file, or regular)
       --bundle-sourcemap <BUNDLE_SOURCEMAP>
           Path to the bundle sourcemap
-      --no-dedupe
-          Skip artifacts deduplication prior to uploading. This will force all artifacts to be
-          uploaded, no matter whether they are already present on the server.
   -x, --ext <EXT>
           Set the file extensions that are considered for upload. This overrides the default
           extensions. To add an extension, all default extensions must be repeated. Specify once per