Skip to content

Commit 0387052

Browse files
ref(build): Use u32 instead of &u32 in VcsInfo (#3000)
`u32` is `Copy`, and it is also smaller than a `&u32` (at least, on 64-bit systems). `u32` is also simpler to use, so there's no reason not to use it.
1 parent bc124fc commit 0387052

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/api/data_types/chunking/build.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,5 @@ pub struct VcsInfo<'a> {
4242
#[serde(skip_serializing_if = "str::is_empty")]
4343
pub base_ref: &'a str,
4444
#[serde(skip_serializing_if = "Option::is_none")]
45-
pub pr_number: Option<&'a u32>,
45+
pub pr_number: Option<u32>,
4646
}

src/commands/build/upload.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
341341
base_repo_name: &base_repo_name,
342342
head_ref: &head_ref,
343343
base_ref: &base_ref,
344-
pr_number: pr_number.as_ref(),
344+
pr_number,
345345
};
346346
match upload_file(
347347
&authenticated_api,

0 commit comments

Comments
 (0)