Skip to content

Commit acb6caa

Browse files
runningcodeclaude
andcommitted
refactor: Remove redundant docstrings from metadata_extractor (EME-606)
Removed docstrings that repeated what the code already expressed through clear function names and type hints. Kept only the format example in _parse_metadata_content as it provides useful context. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 0a59a68 commit acb6caa

File tree

2 files changed

+1
-27
lines changed

2 files changed

+1
-27
lines changed

src/launchpad/utils/metadata_extractor.py

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313

1414

1515
class ToolingMetadata:
16-
"""Container for tooling version metadata extracted from artifacts."""
17-
1816
def __init__(
1917
self,
2018
cli_version: Optional[str] = None,
@@ -30,14 +28,6 @@ def __repr__(self) -> str:
3028

3129

3230
def extract_metadata_from_zip(zip_path: Path) -> ToolingMetadata:
33-
"""Extract tooling metadata from a .sentry-cli-metadata.txt file in the root of a zip.
34-
35-
Args:
36-
zip_path: Path to the zip file to search
37-
38-
Returns:
39-
ToolingMetadata object with extracted version information
40-
"""
4131
try:
4232
with zipfile.ZipFile(zip_path, "r") as zf:
4333
# Only look for .sentry-cli-metadata.txt in the root of the zip
@@ -57,18 +47,10 @@ def extract_metadata_from_zip(zip_path: Path) -> ToolingMetadata:
5747

5848

5949
def _parse_metadata_content(content: str) -> ToolingMetadata:
60-
"""Parse the content of .sentry-cli-metadata.txt file.
61-
62-
Expected format:
50+
"""Expected format:
6351
sentry-cli-version: 2.58.2
6452
sentry-fastlane-plugin: 1.2.3
6553
sentry-gradle-plugin: 4.12.0
66-
67-
Args:
68-
content: The text content of the metadata file
69-
70-
Returns:
71-
ToolingMetadata object with parsed version information
7254
"""
7355
metadata: Dict[str, str] = {}
7456

tests/unit/utils/test_metadata_extractor.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
"""Tests for metadata extraction from .sentry-cli-metadata.txt files."""
2-
31
import tempfile
42
import zipfile
53

@@ -13,8 +11,6 @@
1311

1412

1513
class TestParseMetadataContent:
16-
"""Tests for parsing .sentry-cli-metadata.txt content."""
17-
1814
def test_parse_all_fields(self):
1915
content = """sentry-cli-version: 2.58.2
2016
sentry-fastlane-plugin: 1.2.3
@@ -33,8 +29,6 @@ def test_parse_empty_content(self):
3329

3430

3531
class TestExtractMetadataFromZip:
36-
"""Tests for extracting metadata from zip files."""
37-
3832
def test_extract_from_zip_root(self):
3933
with tempfile.NamedTemporaryFile(suffix=".zip", delete=False) as tf:
4034
try:
@@ -68,8 +62,6 @@ def test_extract_when_missing(self):
6862

6963

7064
class TestToolingMetadata:
71-
"""Tests for ToolingMetadata container class."""
72-
7365
def test_create_with_defaults(self):
7466
metadata = ToolingMetadata()
7567
assert metadata.cli_version is None

0 commit comments

Comments
 (0)