Skip to content

Commit 1281aa7

Browse files
runningcodeclaude
andcommitted
refactor: Rename fastlane_version to fastlane_plugin_version (EME-606)
Makes field naming consistent by using "plugin_version" suffix for both fastlane_plugin_version and gradle_plugin_version. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 5d5b2d4 commit 1281aa7

File tree

7 files changed

+24
-23
lines changed

7 files changed

+24
-23
lines changed

src/launchpad/api/update_api_models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ class UpdateData(BaseModel):
6464
android_app_info: Optional[AndroidAppInfo] = None
6565
dequeued_at: Optional[datetime] = Field(None, description="Timestamp when message was dequeued from Kafka")
6666
cli_version: Optional[str] = Field(None, description="sentry-cli version extracted from .sentry-cli-metadata.txt")
67-
fastlane_version: Optional[str] = Field(None, description="Fastlane plugin version extracted from .sentry-cli-metadata.txt")
67+
fastlane_plugin_version: Optional[str] = Field(None, description="Fastlane plugin version extracted from .sentry-cli-metadata.txt")
6868
gradle_plugin_version: Optional[str] = Field(None, description="Gradle plugin version extracted from .sentry-cli-metadata.txt")
6969

7070
@field_serializer("dequeued_at")

src/launchpad/artifact_processor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ def _get_artifact_type(artifact: Artifact) -> ArtifactType:
527527
android_app_info=android_app_info,
528528
dequeued_at=dequeued_at,
529529
cli_version=app_info.cli_version,
530-
fastlane_version=app_info.fastlane_version,
530+
fastlane_plugin_version=app_info.fastlane_plugin_version,
531531
gradle_plugin_version=app_info.gradle_plugin_version,
532532
)
533533

src/launchpad/size/analyzers/android.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def preprocess(self, artifact: AndroidArtifact) -> AndroidAppInfo:
6565
app_id=manifest_dict["package_name"],
6666
has_proguard_mapping=has_proguard_mapping,
6767
cli_version=metadata.cli_version,
68-
fastlane_version=metadata.fastlane_version,
68+
fastlane_plugin_version=metadata.fastlane_plugin_version,
6969
gradle_plugin_version=metadata.gradle_plugin_version,
7070
)
7171

src/launchpad/size/analyzers/apple.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ def _extract_app_info(self, xcarchive: ZippedXCArchive) -> AppleAppInfo:
332332
alternate_icon_names=alternate_icon_names,
333333
missing_dsym_binaries=missing_dsym_binaries,
334334
cli_version=metadata.cli_version,
335-
fastlane_version=metadata.fastlane_version,
335+
fastlane_plugin_version=metadata.fastlane_plugin_version,
336336
gradle_plugin_version=metadata.gradle_plugin_version,
337337
)
338338

src/launchpad/size/models/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class BaseAppInfo(BaseModel):
2323
build: str = Field(..., description="Build number")
2424
app_id: str = Field(..., description="App ID (bundle id on iOS, package name on Android)")
2525
cli_version: str | None = Field(None, description="sentry-cli version extracted from .sentry-cli-metadata.txt")
26-
fastlane_version: str | None = Field(None, description="Fastlane plugin version extracted from .sentry-cli-metadata.txt")
26+
fastlane_plugin_version: str | None = Field(None, description="Fastlane plugin version extracted from .sentry-cli-metadata.txt")
2727
gradle_plugin_version: str | None = Field(None, description="Gradle plugin version extracted from .sentry-cli-metadata.txt")
2828

2929

src/launchpad/utils/metadata_extractor.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ class ToolingMetadata:
1818
def __init__(
1919
self,
2020
cli_version: Optional[str] = None,
21-
fastlane_version: Optional[str] = None,
21+
fastlane_plugin_version: Optional[str] = None,
2222
gradle_plugin_version: Optional[str] = None,
2323
):
2424
self.cli_version = cli_version
25-
self.fastlane_version = fastlane_version
25+
self.fastlane_plugin_version = fastlane_plugin_version
2626
self.gradle_plugin_version = gradle_plugin_version
2727

2828
def __repr__(self) -> str:
29-
return f"ToolingMetadata(cli_version={self.cli_version}, fastlane_version={self.fastlane_version}, gradle_plugin_version={self.gradle_plugin_version})"
29+
return f"ToolingMetadata(cli_version={self.cli_version}, fastlane_plugin_version={self.fastlane_plugin_version}, gradle_plugin_version={self.gradle_plugin_version})"
3030

3131

3232
def extract_metadata_from_zip(zip_path: Path) -> ToolingMetadata:
@@ -89,6 +89,6 @@ def _parse_metadata_content(content: str) -> ToolingMetadata:
8989

9090
return ToolingMetadata(
9191
cli_version=metadata.get("sentry-cli-version"),
92-
fastlane_version=metadata.get("fastlane-plugin"),
92+
fastlane_plugin_version=metadata.get("fastlane-plugin"),
9393
gradle_plugin_version=metadata.get("gradle-plugin"),
9494
)

tests/unit/utils/test_metadata_extractor.py

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,29 +21,29 @@ def test_parse_all_fields(self):
2121
gradle-plugin: 4.12.0"""
2222
metadata = _parse_metadata_content(content)
2323
assert metadata.cli_version == "2.58.2"
24-
assert metadata.fastlane_version == "1.2.3"
24+
assert metadata.fastlane_plugin_version == "1.2.3"
2525
assert metadata.gradle_plugin_version == "4.12.0"
2626

2727
def test_parse_partial_fields(self):
2828
content = """sentry-cli-version: 2.58.2
2929
fastlane-plugin: 1.2.3"""
3030
metadata = _parse_metadata_content(content)
3131
assert metadata.cli_version == "2.58.2"
32-
assert metadata.fastlane_version == "1.2.3"
32+
assert metadata.fastlane_plugin_version == "1.2.3"
3333
assert metadata.gradle_plugin_version is None
3434

3535
def test_parse_only_cli_version(self):
3636
content = "sentry-cli-version: 2.58.2"
3737
metadata = _parse_metadata_content(content)
3838
assert metadata.cli_version == "2.58.2"
39-
assert metadata.fastlane_version is None
39+
assert metadata.fastlane_plugin_version is None
4040
assert metadata.gradle_plugin_version is None
4141

4242
def test_parse_empty_content(self):
4343
content = ""
4444
metadata = _parse_metadata_content(content)
4545
assert metadata.cli_version is None
46-
assert metadata.fastlane_version is None
46+
assert metadata.fastlane_plugin_version is None
4747
assert metadata.gradle_plugin_version is None
4848

4949
def test_parse_with_extra_whitespace(self):
@@ -52,7 +52,7 @@ def test_parse_with_extra_whitespace(self):
5252
gradle-plugin: 4.12.0 """
5353
metadata = _parse_metadata_content(content)
5454
assert metadata.cli_version == "2.58.2"
55-
assert metadata.fastlane_version == "1.2.3"
55+
assert metadata.fastlane_plugin_version == "1.2.3"
5656
assert metadata.gradle_plugin_version == "4.12.0"
5757

5858
def test_parse_with_extra_lines(self):
@@ -65,7 +65,7 @@ def test_parse_with_extra_lines(self):
6565
"""
6666
metadata = _parse_metadata_content(content)
6767
assert metadata.cli_version == "2.58.2"
68-
assert metadata.fastlane_version == "1.2.3"
68+
assert metadata.fastlane_plugin_version == "1.2.3"
6969
assert metadata.gradle_plugin_version == "4.12.0"
7070

7171
def test_parse_with_unknown_fields(self):
@@ -74,7 +74,7 @@ def test_parse_with_unknown_fields(self):
7474
fastlane-plugin: 1.2.3"""
7575
metadata = _parse_metadata_content(content)
7676
assert metadata.cli_version == "2.58.2"
77-
assert metadata.fastlane_version == "1.2.3"
77+
assert metadata.fastlane_plugin_version == "1.2.3"
7878
assert metadata.gradle_plugin_version is None
7979

8080

@@ -93,7 +93,7 @@ def test_extract_from_zip_root(self):
9393

9494
metadata = extract_metadata_from_zip(Path(tf.name))
9595
assert metadata.cli_version == "2.58.2"
96-
assert metadata.fastlane_version == "1.2.3"
96+
assert metadata.fastlane_plugin_version == "1.2.3"
9797
assert metadata.gradle_plugin_version == "4.12.0"
9898
finally:
9999
Path(tf.name).unlink()
@@ -110,7 +110,7 @@ def test_extract_from_nested_path(self):
110110

111111
metadata = extract_metadata_from_zip(Path(tf.name))
112112
assert metadata.cli_version == "3.0.0"
113-
assert metadata.fastlane_version is None
113+
assert metadata.fastlane_plugin_version is None
114114
assert metadata.gradle_plugin_version is None
115115
finally:
116116
Path(tf.name).unlink()
@@ -124,7 +124,7 @@ def test_extract_when_missing(self):
124124

125125
metadata = extract_metadata_from_zip(Path(tf.name))
126126
assert metadata.cli_version is None
127-
assert metadata.fastlane_version is None
127+
assert metadata.fastlane_plugin_version is None
128128
assert metadata.gradle_plugin_version is None
129129
finally:
130130
Path(tf.name).unlink()
@@ -158,7 +158,7 @@ def test_extract_from_invalid_zip(self):
158158
metadata = extract_metadata_from_zip(Path(tf.name))
159159
# Should return empty metadata on error
160160
assert metadata.cli_version is None
161-
assert metadata.fastlane_version is None
161+
assert metadata.fastlane_plugin_version is None
162162
assert metadata.gradle_plugin_version is None
163163
finally:
164164
Path(tf.name).unlink()
@@ -170,21 +170,22 @@ class TestToolingMetadata:
170170
def test_create_with_all_fields(self):
171171
metadata = ToolingMetadata(
172172
cli_version="2.58.2",
173-
fastlane_version="1.2.3",
173+
fastlane_plugin_version="1.2.3",
174174
gradle_plugin_version="4.12.0",
175175
)
176176
assert metadata.cli_version == "2.58.2"
177-
assert metadata.fastlane_version == "1.2.3"
177+
assert metadata.fastlane_plugin_version == "1.2.3"
178178
assert metadata.gradle_plugin_version == "4.12.0"
179179

180180
def test_create_with_defaults(self):
181181
metadata = ToolingMetadata()
182182
assert metadata.cli_version is None
183-
assert metadata.fastlane_version is None
183+
assert metadata.fastlane_plugin_version is None
184184
assert metadata.gradle_plugin_version is None
185185

186186
def test_repr(self):
187187
metadata = ToolingMetadata(cli_version="2.58.2")
188188
repr_str = repr(metadata)
189189
assert "ToolingMetadata" in repr_str
190190
assert "cli_version=2.58.2" in repr_str
191+
assert "fastlane_plugin_version" in repr_str

0 commit comments

Comments
 (0)