Backporting from v3

Author: gershnik

lib/inc/sys_string/impl/compare.h

@@ -64,7 +64,7 @@ namespace sysstr
     }
 
     template<class Storage>
-    auto sys_string_t<Storage>::compare_no_case(const sys_string_t<Storage> lhs, const sys_string_t<Storage> & rhs) noexcept -> compare_result
+    auto sys_string_t<Storage>::compare_no_case(const sys_string_t<Storage> & lhs, const sys_string_t<Storage> & rhs) noexcept -> compare_result
     {
         utf32_view lhs_view(lhs);
         utf32_view rhs_view(rhs);

lib/inc/sys_string/sys_string.h

@@ -234,7 +234,7 @@ namespace sysstr
 
         friend auto compare(const sys_string_t & lhs, const sys_string_t & rhs) noexcept -> compare_result
             { return sys_string_t::compare(lhs, rhs); }
-        friend auto compare_no_case(const sys_string_t lhs, const sys_string_t & rhs) noexcept -> compare_result
+        friend auto compare_no_case(const sys_string_t & lhs, const sys_string_t & rhs) noexcept -> compare_result
             { return sys_string_t::compare_no_case(lhs, rhs); }
 
         template<class StringOrChar1, class StringOrChar2>
@@ -313,7 +313,7 @@ namespace sysstr
 
     private:
         static auto compare(const sys_string_t & lhs, const sys_string_t & rhs) noexcept -> compare_result;
-        static auto compare_no_case(const sys_string_t lhs, const sys_string_t & rhs) noexcept -> compare_result;
+        static auto compare_no_case(const sys_string_t & lhs, const sys_string_t & rhs) noexcept -> compare_result;
 
     };