Skip to content

Commit e8e9d3c

Browse files
authored
Updates after setting up project on a new machine (#170)
1 parent 206018b commit e8e9d3c

File tree

15 files changed

+21
-17
lines changed

15 files changed

+21
-17
lines changed

.github/actions/unit-test/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ runs:
88
shell: bash
99
run: |
1010
set -Eeuo pipefail
11-
# This Gradle task runs across all compisite build projects and because it's invoked from
12-
# the root it'll try to use concurrent yarn instances that all try to write to the same output
11+
# This Gradle task runs across all composite build projects and because it's invoked from
12+
# the root it'll try to use concurrent yarn instances that all try to write to the same cache
1313
# folder. A single Gradle worker avoids this at the cost of a slower build but this is okay for now.
1414
./gradlew --no-daemon --continue --max-workers=1 jsTest
1515
- name: Generate test report

.github/workflows/nightly-check.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ jobs:
2828
- name: Build services
2929
run: |
3030
set -Eeuo pipefail
31-
# This Gradle task runs across all compisite build projects and because it's invoked from
32-
# the root it'll try to use concurrent yarn instances that all try to write to the same output
31+
# This Gradle task runs across all composite build projects and because it's invoked from
32+
# the root it'll try to use concurrent yarn instances that all try to write to the same cache
3333
# folder. A single Gradle worker avoids this at the cost of a slower build but this is okay for now.
3434
./gradlew --no-daemon --max-workers=1 assemble
3535
- name: Preview infrastructure

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ bower_components
2929
# node-waf configuration
3030
.lock-wscript
3131

32-
# Compiled binary addons (http://nodejs.org/api/addons.html)
33-
build/Release
32+
# Compiled binaries
33+
build/
3434

3535
# Dependency directories
3636
node_modules/

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ GOOGLE_ANALYTICS_MEASUREMENT_ID=YOUR_ANALYTICS_MEASUREMENT_ID
105105
GOOGLE_ANALYTICS_API_SECRET=YOUR_ANALYTICS_API_SECRET
106106
```
107107
7. Copy the `credentials-gcp-app.json` Service Account JSON API key to the root project folder.
108+
8. Make sure you select the right Java version. If you don't have it installed locally, use latest Azul Zulu on Intellij
108109
</details>
109110

110111
## Run locally

common/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#Gradle
2-
org.gradle.jvmargs=-Xmx4g -XX:MaxPermSize=1g "-XX:MaxMetaspaceSize=2g"
2+
org.gradle.jvmargs=-Xmx4g "-XX:MaxMetaspaceSize=2g"
33
org.gradle.caching=true
44
org.gradle.parallel=true
55

gradle-plugins/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#Gradle
2-
org.gradle.jvmargs=-Xmx4g -XX:MaxPermSize=1g "-XX:MaxMetaspaceSize=2g"
2+
org.gradle.jvmargs=-Xmx4g "-XX:MaxMetaspaceSize=2g"
33
org.gradle.caching=true
44
org.gradle.parallel=true
55

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
#Gradle
2-
org.gradle.jvmargs=-Xmx4g -XX:MaxPermSize=1g "-XX:MaxMetaspaceSize=2g"
2+
org.gradle.jvmargs=-Xmx4g "-XX:MaxMetaspaceSize=2g"
33
org.gradle.caching=true
44
org.gradle.parallel=true

landing-page-web/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#Gradle
2-
org.gradle.jvmargs=-Xmx4g -XX:MaxPermSize=1g "-XX:MaxMetaspaceSize=2g"
2+
org.gradle.jvmargs=-Xmx4g "-XX:MaxMetaspaceSize=2g"
33
org.gradle.caching=true
44
org.gradle.parallel=true
55

proxy-web/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#Gradle
2-
org.gradle.jvmargs=-Xmx4g -XX:MaxPermSize=1g "-XX:MaxMetaspaceSize=2g"
2+
org.gradle.jvmargs=-Xmx4g "-XX:MaxMetaspaceSize=2g"
33
org.gradle.caching=true
44
org.gradle.parallel=true
55

search/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#Gradle
2-
org.gradle.jvmargs=-Xmx4g -XX:MaxPermSize=1g "-XX:MaxMetaspaceSize=2g"
2+
org.gradle.jvmargs=-Xmx4g "-XX:MaxMetaspaceSize=2g"
33
org.gradle.caching=true
44
org.gradle.parallel=true
55

0 commit comments

Comments
 (0)