Add basic tests for If and Exists

Update tests

Author: mostafa

config/constants.go

@@ -146,7 +146,7 @@ const (
 	DefaultGRPCAPINetwork = "tcp"
 	DefaultGRPCAPIAddress = "localhost:19090"
 
-	// Policies
+	// Policies.
 	DefaultCompatibilityPolicy = Strict
 	DefaultVerificationPolicy  = PassDown
 	DefaultAcceptancePolicy    = Accept

config/getters_test.go

@@ -3,108 +3,16 @@ package config
 import (
 	"context"
 	"testing"
-	"time"
 
-	"github.com/rs/zerolog"
 	"github.com/stretchr/testify/assert"
 )
 
-// TestGetVerificationPolicy tests the GetVerificationPolicy function.
-func TestGetVerificationPolicy(t *testing.T) {
-	pluginConfig := PluginConfig{}
-	assert.Equal(t, PassDown, pluginConfig.GetVerificationPolicy())
-}
-
-// TestGetPluginCompatibilityPolicy tests the GetPluginCompatibilityPolicy function.
-func TestGetPluginCompatibilityPolicy(t *testing.T) {
-	pluginConfig := PluginConfig{}
-	assert.Equal(t, Strict, pluginConfig.GetPluginCompatibilityPolicy())
-}
-
-// TestGetAcceptancePolicy tests the GetAcceptancePolicy function.
-func TestGetAcceptancePolicy(t *testing.T) {
-	pluginConfig := PluginConfig{}
-	assert.Equal(t, Accept, pluginConfig.GetAcceptancePolicy())
-}
-
-// TestGetTerminationPolicy tests the GetTerminationPolicy function.
-func TestGetTerminationPolicy(t *testing.T) {
-	pluginConfig := PluginConfig{}
-	assert.Equal(t, Stop, pluginConfig.GetTerminationPolicy())
-}
-
-// TestGetTCPKeepAlivePeriod tests the GetTCPKeepAlivePeriod function.
-func TestGetTCPKeepAlivePeriod(t *testing.T) {
-	client := Client{}
-	assert.Equal(t, client.GetTCPKeepAlivePeriod(), time.Duration(0))
-}
-
-// TestGetReceiveDeadline tests the GetReceiveDeadline function.
-func TestGetReceiveDeadline(t *testing.T) {
-	client := Client{}
-	assert.Equal(t, time.Duration(0), client.GetReceiveDeadline())
-}
-
-// TestGetReceiveTimeout tests the GetReceiveTimeout function.
-func TestGetReceiveTimeout(t *testing.T) {
-	client := Client{}
-	assert.Equal(t, time.Duration(0), client.GetReceiveTimeout())
-}
-
-// TestGetSendDeadline tests the GetSendDeadline function.
-func TestGetSendDeadline(t *testing.T) {
-	client := Client{}
-	assert.Equal(t, time.Duration(0), client.GetSendDeadline())
-}
-
-// TestGetReceiveChunkSize tests the GetReceiveChunkSize function.
-func TestGetReceiveChunkSize(t *testing.T) {
-	client := Client{}
-	assert.Equal(t, DefaultChunkSize, client.GetReceiveChunkSize())
-}
-
-// TestGetHealthCheckPeriod tests the GetHealthCheckPeriod function.
-func TestGetHealthCheckPeriod(t *testing.T) {
-	proxy := Proxy{}
-	assert.Equal(t, DefaultHealthCheckPeriod, proxy.GetHealthCheckPeriod())
-}
-
-// TestGetTickInterval tests the GetTickInterval function.
-func TestGetTickInterval(t *testing.T) {
-	server := Server{}
-	assert.Equal(t, server.GetTickInterval(), time.Duration(0))
-}
-
-// TestGetSize tests the GetSize function.
-func TestGetSize(t *testing.T) {
-	pool := Pool{}
-	assert.Equal(t, DefaultPoolSize, pool.GetSize())
-}
-
 // TestGetOutput tests the GetOutput function.
 func TestGetOutput(t *testing.T) {
 	logger := Logger{}
 	assert.Equal(t, []LogOutput{Console}, logger.GetOutput())
 }
 
-// TestGetTimeFormat tests the GetTimeFormat function.
-func TestGetTimeFormat(t *testing.T) {
-	logger := Logger{}
-	assert.Equal(t, zerolog.TimeFormatUnix, logger.GetTimeFormat())
-}
-
-// TestGetConsoleTimeFormat tests the GetConsoleTimeFormat function.
-func TestGetConsoleTimeFormat(t *testing.T) {
-	logger := Logger{}
-	assert.Equal(t, time.RFC3339, logger.GetConsoleTimeFormat())
-}
-
-// TestGetLevel tests the GetLevel function.
-func TestGetLevel(t *testing.T) {
-	logger := Logger{}
-	assert.Equal(t, zerolog.InfoLevel, logger.GetLevel())
-}
-
 // TestGetPlugins tests the GetPlugins function.
 func TestGetPlugins(t *testing.T) {
 	plugin := Plugin{Name: "plugin1"}
@@ -117,18 +25,6 @@ func TestGetDefaultConfigFilePath(t *testing.T) {
 	assert.Equal(t, GlobalConfigFilename, GetDefaultConfigFilePath(GlobalConfigFilename))
 }
 
-// TestGetReadTimeout tests the GetReadTimeout function.
-func TestGetReadHeaderTimeout(t *testing.T) {
-	metrics := Metrics{}
-	assert.Equal(t, metrics.GetReadHeaderTimeout(), time.Duration(0))
-}
-
-// TestGetTimeout tests the GetTimeout function of the metrics server.
-func TestGetTimeout(t *testing.T) {
-	metrics := Metrics{}
-	assert.Equal(t, metrics.GetTimeout(), time.Duration(0))
-}
-
 // TestFilter tests the Filter function.
 func TestFilter(t *testing.T) {
 	// Load config from the default config file.

config/getters_windows.go

@@ -3,14 +3,7 @@
 
 package config
 
-import "github.com/rs/zerolog"
-
 // GetSyslogPriority returns zero value for Windows.
 func (l Logger) GetSyslogPriority() int {
 	return 0
 }
-
-// GetSystemLimits returns zero values for Windows.
-func (s Server) GetRLimits(logger zerolog.Logger) (uint64, uint64) {
-	return 0, 0
-}

config/utils.go

@@ -9,6 +9,8 @@ func If[T any](predicate bool, truthy, falsy T) T {
 }
 
 // Exists returns true if key exists in map_, false otherwise.
+//
+//nolint:revive
 func Exists[T comparable, V any](map_ map[T]V, key T) bool {
 	_, ok := map_[key]
 	return ok

config/utils_test.go

@@ -0,0 +1,22 @@
+package config
+
+import "testing"
+
+func TestIf(t *testing.T) {
+	if If(true, 1, 2) != 1 {
+		t.Error("If(true, 1, 2) != 1")
+	}
+	if If(false, 1, 2) != 2 {
+		t.Error("If(false, 1, 2) != 2")
+	}
+}
+
+func TestExists(t *testing.T) {
+	m := map[string]int{"a": 1, "b": 2}
+	if !Exists(m, "a") {
+		t.Error("Exists(m, \"a\") != true")
+	}
+	if Exists(m, "c") {
+		t.Error("Exists(m, \"c\") != false")
+	}
+}

network/client.go

@@ -411,10 +411,12 @@ func (c *Client) LocalAddr() string {
 }
 
 // Retry returns the retry object.
+//
+//nolint:revive
 func (c *Client) Retry() *Retry {
-	if _, ok := c.retry.(*Retry); !ok {
+	if retry, ok := c.retry.(*Retry); !ok {
 		return nil
 	} else {
-		return c.retry.(*Retry)
+		return retry
 	}
 }