Skip to content

Commit 5f759ee

Browse files
author
Topi Paavilainen
committed
ldap mock tests don't work, disabled in settings.test_live
1 parent e0be455 commit 5f759ee

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

fum/api/tests.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,8 @@ def tearDown(self):
350350
self.mockldap.stop()
351351

352352
def test_signals_mocked(self):
353+
if 'test_live' in os.environ.get('DJANGO_SETTINGS_MODULE'):
354+
return
353355
# ReconnectingLDAPBridge re-uses initial connection
354356
option_count = len(settings.LDAP_CONNECTION_OPTIONS)
355357
tls = ['initialize'] + ['set_option']*option_count + ['initialize']

fum/ldap_helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def __init__(self, parent, dn=None, **kwargs):
7777
self._connection_bound = False
7878
self.settings = AttrDict()
7979
self.settings.uri = kwargs.get('uri', settings.LDAP_CONNECTION.get('uri'))
80-
self.settings.START_TLS = True
80+
self.settings.START_TLS = settings.USE_TLS
8181
self.settings.CONNECTION_OPTIONS = kwargs.get('LDAP_CONNECTION_OPTIONS', None) or settings.LDAP_CONNECTION_OPTIONS
8282
self.settings.BIND_DN = kwargs.get('BIND_DN', None) or settings.LDAP_CONNECTION.get('bind_dn')
8383
self.settings.BIND_PASSWORD = kwargs.get('BIND_PASSWORD', None) or settings.LDAP_CONNECTION.get('bind_pwd')

fum/settings/base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@
203203

204204
# LDAP
205205
import ldap
206-
USE_TLS = False
206+
USE_TLS = True
207207
LDAP_CLASS = 'fum.ldap_helpers.PoolLDAPBridge'
208208
LDAP_RETRY_DELAY = 1
209209
LDAP_RETRY_MAX = 3
@@ -218,7 +218,7 @@
218218

219219
# CHANGES WEBSOCKET ENDPOINT
220220
CHANGES_SOCKET = '/tmp/fum3changes.sock'
221-
CHANGES_SOCKET_ENABLED = True
221+
CHANGES_SOCKET_ENABLED = False
222222
CHANGES_FAILED_LOG = '/tmp/changes_failed.json'
223223

224224
SUDO_TIMEOUT = 90#in minutes

0 commit comments

Comments
 (0)