Skip to content

Commit 5266337

Browse files
committed
Merge pull request #63 from futurice/search-field-fix
Search field fix
2 parents f788909 + 7b38696 commit 5266337

File tree

6 files changed

+14
-2
lines changed

6 files changed

+14
-2
lines changed

fum/api/views.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,10 @@ def mod_groups(request, user, usergroups, classname):
159159
elif request.method == 'POST':
160160
for group in groups:
161161
if user not in group.users.all():
162-
group.users.add(user)
162+
try:
163+
group.users.add(user)
164+
except ValidationError as e:
165+
return Response(e.messages, status=status.HTTP_400_BAD_REQUEST)
163166

164167
json_groups = []
165168
for group in usergroups.all().values().order_by():

fum/common/static/js/marcopolo2.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ function marcopoloField2(el, opt){
2121
err = err.responseText;
2222
};
2323
fumErrors.set('marcopolo', err, 'error');
24+
$.getJSON(apiUrl, updateTable);
2425
}
2526

2627
var delicon = '<i class="icon-remove pull-right"></i>';

fum/groups/views.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ def groups_json(request):
7272
user = Users.objects.get(username=request.META['REMOTE_USER'])
7373
try:
7474
q = request.GET['q']
75+
q = q.strip()
7576
filtered = Groups.objects.filter(name__icontains=q)
7677
groups = []
7778
for group in filter_by_permissions(request, user, filtered.distinct()):

fum/projects/views.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ def projects_json(request):
7070
user = Users.objects.get(username = request.META['REMOTE_USER'])
7171
try:
7272
q = request.GET['q']
73+
q = q.strip()
7374
filtered = Projects.objects.filter(name__icontains=q)
7475
projects = []
7576
for project in filter_by_permissions(request, user, filtered.distinct()):

fum/servers/views.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ def servers_json(request):
7171
user = Users.objects.get(username = request.META['REMOTE_USER'])
7272
try:
7373
q = request.GET['q']
74+
q = q.strip()
7475
filtered = Servers.objects.filter(name__icontains=q)
7576
servers = []
7677
for server in filter_by_permissions(request, user, filtered.distinct()):

fum/users/views.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,12 @@ def get_success_url(self):
5353
def users_json(request):
5454
try:
5555
q = request.GET['q']
56-
filtered = Users.objects.filter(Q(first_name__icontains=q) | Q(last_name__icontains=q) | Q(username__icontains=q))
56+
search_terms = q.split()
57+
58+
filtered = Users.objects
59+
for word in search_terms:
60+
filtered = filtered.filter(Q(first_name__icontains=word) | Q(last_name__icontains=word) | Q(username__icontains=word))
61+
5762
users = []
5863
for user in filtered.distinct():
5964
json_user={}

0 commit comments

Comments
 (0)